Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add travis and more gemfiles #28

Merged
merged 1 commit into from Jan 20, 2012

Conversation

Projects
None yet
2 participants
Collaborator

nashby commented Jan 20, 2012

don't forget to add notifications config and travis build image.

@rafaelfranca rafaelfranca and 1 other commented on an outdated diff Jan 20, 2012

show_for.gemspec
@@ -18,6 +18,6 @@ Gem::Specification.new do |s|
s.rubyforge_project = "show_for"
- s.add_dependency('activemodel', '~> 3.0')
- s.add_dependency('actionpack', '~> 3.0')
+ s.add_dependency('activemodel', '>= 3.0.0.rc', '< 4.0')
@rafaelfranca

rafaelfranca Jan 20, 2012

Collaborator

We don't need to change it anymore since Rails 3.2 came out

@nashby

nashby Jan 20, 2012

Collaborator

it should be "~> 3.2.0", right?

@rafaelfranca

rafaelfranca Jan 20, 2012

Collaborator

No. Only "~> 3.0"

@nashby

nashby Jan 20, 2012

Collaborator

updated. looks like the same problems that devise has with ree. http://travis-ci.org/#!/nashby/show_for/jobs/550596

@rafaelfranca

rafaelfranca Jan 20, 2012

Collaborator

Yeah. This seems like a rubygems error at Travis-CI

@rafaelfranca rafaelfranca added a commit that referenced this pull request Jan 20, 2012

@rafaelfranca rafaelfranca Merge pull request #28 from nashby/add-travis
add travis and more gemfiles
582daa6

@rafaelfranca rafaelfranca merged commit 582daa6 into plataformatec:master Jan 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment