Permalink
Commits on Aug 26, 2016
  1. @lucasmazza

    Release 3.3.1.

    lucasmazza committed Aug 26, 2016
  2. @lucasmazza

    Merge pull request #1422 from tjgrathwell/stringify-argument-to-type_…

    …for_attribute
    
    Ensure the arg sent to `type_for_attribute` is a string
    lucasmazza committed on GitHub Aug 26, 2016
  3. @tjgrathwell

    Ensure the arg sent to `type_for_attribute` is a string

    Per the docs, it is required to be a string:
    http://api.rubyonrails.org/v5.0.0/classes/ActiveRecord/ModelSchema/ClassMethods.html#method-i-type_for_attribute
    
    If you send a symbol, you will get an empty
    ActiveRecord::Type::Value instance instead of the actual
    column type you might have expected.
    
    Since `f.input [attr]` can otherwise be invoked with
    either a symbol or string, it seems important to
    support both.
    
    Fixes #1421
    tjgrathwell committed Aug 26, 2016
Commits on Aug 25, 2016
  1. @lucasmazza

    Release 3.3.0.

    lucasmazza committed Aug 25, 2016
  2. @lucasmazza

    Update CHANGELOG.

    lucasmazza committed Aug 25, 2016
  3. @lucasmazza

    Merge pull request #1417 from plataformatec/lm-activemodel-type-api

    Support the ActiveModel::Type API when available
    lucasmazza committed on GitHub Aug 25, 2016
  4. @lucasmazza

    Merge pull request #1416 from petrgazarov/do-not-ignore-implicitly-pa…

    …ssed-required-option
    
    Do not ignore implicitly passed required option
    lucasmazza committed on GitHub Aug 25, 2016
Commits on Aug 19, 2016
  1. @rafaelfranca

    Merge pull request #1419 from petrgazarov/clarify-docs-about-validati…

    …ons-required-attribute-behavior
    
    Clarify docs about required attribute behavior
    rafaelfranca committed on GitHub Aug 19, 2016
  2. @petrgazarov
Commits on Aug 13, 2016
  1. @petrgazarov
Commits on Aug 12, 2016
  1. @lucasmazza

    Update `country_select` dependency on `5-0-stable` Gemfile.

    lucasmazza committed Aug 12, 2016
  2. @lucasmazza

    Exclude the `5-0-stable` Gemfile with unsupported version of Ruby on …

    …Travis.
    lucasmazza committed Aug 12, 2016
  3. @lucasmazza
  4. @olivierlacan @lucasmazza

    Simplify check for decimal_or_float?

    This simplification should make it compatible with Rails 5's new
    Attributes API without requiring a major refactor of the FormBuilder class.
    
    The motivation for this commit originated in #1342.
    
    @rafaelfranca mentioned that we should be using the new type_for_attribute interface
    to determine the precise type of a column instead. At first I used the interface directly like
    this:
    
          def decimal_or_float?
            if object.respond_to?(:type_for_attribute)
              type = object.type_for_attribute(column.name.to_s).type
              type == :float || :decimal
            else
              column.number? && column.type != :integer
            end
          end
    
    I then realized that we're already asking the column object directly for the type, so
    why not simple check for the two types we care about and implement the method in a much
    more straightforward *and* backward-compatible way? I ended up with this:
    
          def decimal_or_float?
            column.type == :float || :decimal
          end
    
    I could be missing something obvious but this is green in my Rails 5.0.0 app. The tests mock out the now removed number? ActiveModel method
    so I had to remove that:
    method: https://github.com/plataformatec/simple_form/blob/1c389f65594db90a1244d93a00a388b4aea4bcc6/test/support/models.rb#L3-L8
    olivierlacan committed with lucasmazza Jul 2, 2016
  5. @petrgazarov
Commits on Aug 9, 2016
  1. @lucasmazza
  2. @carlosantoniodasilva

    Merge pull request #1414 from voxik/fix-permissions

    Remove executable bit.
    carlosantoniodasilva committed on GitHub Aug 9, 2016
Commits on Aug 8, 2016
  1. @voxik

    Remove executable bit.

    This was accidentaly introduced via f61e570.
    voxik committed Aug 8, 2016
Commits on Jul 28, 2016
  1. @carlosantoniodasilva

    Merge pull request #1411 from heycait/master

    Fix typo and misalignment in comments
    carlosantoniodasilva committed on GitHub Jul 28, 2016
  2. @heycait
Commits on Jul 20, 2016
  1. @rafaelfranca

    Merge pull request #1407 from herminiotorres/hct-merge-wrapper-options

    Merge attributes with wrapper_options
    rafaelfranca committed Jul 20, 2016
  2. @rafaelfranca @herminiotorres
  3. @rafaelfranca @herminiotorres
  4. @herminiotorres

    Merge attributes with wrapper_options

    Improve `merge_wrapper_options` method support other
    types with write, rewrite and merge attributes.
    Herminio Torres committed with herminiotorres Aug 31, 2015
Commits on Jul 13, 2016
  1. @lucasmazza

    Merge pull request #1404 from plataformatec/lm-fix-1314

    Ignore the `:label_text` when rendering `label` tags.
    lucasmazza committed on GitHub Jul 13, 2016
  2. @lucasmazza

    Ignore the `:label_text` option when rendering `label` tags.

    Closes #1314.
    lucasmazza committed Jul 13, 2016
  3. @rafaelfranca

    Merge pull request #1376 from capripot/add_hidden_input_option_to_boo…

    …lean
    
    Add `hidden_input` option to checkbox
    rafaelfranca committed on GitHub Jul 13, 2016
  4. @lucasmazza
Commits on Jul 12, 2016
  1. @rafaelfranca

    Merge pull request #1402 from koenpunt/lazy-load

    only include ActionViewExtensions when ActionView is loaded
    rafaelfranca committed on GitHub Jul 12, 2016
  2. @koenpunt
  3. @koenpunt

    only include ActionViewExtensions when ActionView is loaded

    this resolves a load order issue which I encountered with rspec.
    koenpunt committed Jul 12, 2016
Commits on Jul 5, 2016
  1. @rafaelfranca

    Merge pull request #1396 from herminiotorres/hct-support-rails-5

    Add support Rails 5
    rafaelfranca committed on GitHub Jul 5, 2016
  2. @herminiotorres

    Add support Rails 5.

    herminiotorres committed Jul 1, 2016
Commits on Jul 1, 2016
  1. @lucasmazza

    Merge pull request #1332 from edatrix/patch-1

    Update README.md
    lucasmazza committed on GitHub Jul 1, 2016
  2. @lucasmazza

    Update CHANGELOG.

    lucasmazza committed Jul 1, 2016