Helpers don't filter the options hash v2.0.0.rc

[23inhouse]

The input method only adds real attributes when creating the html output.

For example

   <%= f.input :name, {:label => 'my label'} %>

Will strip the label from the hash and only show the relevant attributes

   <input id="blog_name" class="numeric string optional" type="text" size="50" name="blog[name]">

Here is the bug

The other helper methods label, hint and full_errors don't clean up the options hash and just pass everything through.

For example

   <%= f.label :name, {:label => 'my label', :hint => 'my hint'} %>
   <%= f.hint :name, {:label => 'my label', :hint => 'my hint'} %>

Will NOT clean up the options hash and then adds lots of extra stuff to the html output

   <label class="string required label" hint="my hint." for="blog_name">my label</label>
   <div min_max="false">my hint</div>

[carlosantoniodasilva]

Yeah, this is the API for label, hint, and error helpers: everything you give as extra options are going to end up as html attributes, except for a few given keys on each helper. For instance, the hint helper only uses hint_tag and hint from options, everything else is going straight to html options. Same for label and error.

Anyway, I see now that only label is not handling this correctly, I'm gonna fix it. Besides that, SimpleForm cannot guess what is html attribute, it only knows what is internal use and cleans up such options.

Thanks for reporting.

[carlosantoniodasilva]

Please give it a try bundling from master branch. Thanks.

[23inhouse]

Yes, that is cleaner. Thank you.