Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Have html5 component enabled by default for bootstrap? #471

Closed
isc opened this Issue Feb 24, 2012 · 6 comments

Comments

Projects
None yet
4 participants
Contributor

isc commented Feb 24, 2012

[Title was: simple_form 2.0 ; html5 input types and validations broken]

I couldn't get them to work, had to revert to 1.5.2 .

Collaborator

carlosantoniodasilva commented Feb 24, 2012

What's wrong? What's not working? What behavior changed from 1.5.2? Please give some more info, provide some example code, or a working app showing the issues you're having, thanks.

Owner

josevalim commented Feb 25, 2012

Pasting your config/initializers/simple_form.rb will also help.

@josevalim josevalim closed this Feb 25, 2012

Contributor

isc commented Feb 25, 2012

Sorry for the incomplete report.
After some more investigation I found my mistake.
I got confused by the config file that gets generated using the --bootstrap option. It states b.use :html5 for the wrappers named :default but then defines the :bootstrap wrappers which doesn't use html5 and is then configured as the default_wrapper.
Was it meant for the bootstrap forms to not be using html5 input types by default ?

Owner

josevalim commented Feb 25, 2012

Well, I guess they could have the html5 enabled by default. I believe it would play well with bootstrap.

@josevalim josevalim reopened this Feb 25, 2012

Collaborator

carlosantoniodasilva commented Feb 25, 2012

Agreed, html5 could be enabled by default in bootstrap setup.

@isc would you like to send a pull request with this change?

Thanks.

Collaborator

rafaelfranca commented Feb 25, 2012

Yes please, @isc

@isc isc added a commit to isc/simple_form that referenced this issue Feb 27, 2012

@isc isc adding html5 component by default for the prepend and append wrappers…
… as well - #471
2083ecc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment