MinMax component prints maximum value on form build #483

Closed
julian7 opened this Issue Feb 29, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@julian7
Contributor

julian7 commented Feb 29, 2012

Once I turn on min_max component, it prints out a number after the label, using bootstrap wrapper. I could band-aid it with adding an empty string before line 10 in min_max.rb to return that. However, I can't decide whether it is an adequate solution.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Feb 29, 2012

Collaborator

💣

You can fix this returning nil for min_max method. Like this one

Could you please open a pull request fixing this issue and adding a test to it?

Collaborator

rafaelfranca commented Feb 29, 2012

💣

You can fix this returning nil for min_max method. Like this one

Could you please open a pull request fixing this issue and adding a test to it?

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Feb 29, 2012

Collaborator

Ow Lord, you're completely right, we missed that. Your fix is basically right as well, but we are returning nil instead, like in the maxlength component. Could you please send us a pull request with this fix in place? Thanks!

Collaborator

carlosantoniodasilva commented Feb 29, 2012

Ow Lord, you're completely right, we missed that. Your fix is basically right as well, but we are returning nil instead, like in the maxlength component. Could you please send us a pull request with this fix in place? Thanks!

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Feb 29, 2012

Collaborator

@rafaelfranca lol, here we go :D

Collaborator

carlosantoniodasilva commented Feb 29, 2012

@rafaelfranca lol, here we go :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment