Skip to content

Loading…

MinMax component prints maximum value on form build #483

Closed
julian7 opened this Issue · 3 comments

3 participants

@julian7

Once I turn on min_max component, it prints out a number after the label, using bootstrap wrapper. I could band-aid it with adding an empty string before line 10 in min_max.rb to return that. However, I can't decide whether it is an adequate solution.

@rafaelfranca

:bomb:

You can fix this returning nil for min_max method. Like this one

Could you please open a pull request fixing this issue and adding a test to it?

@carlosantoniodasilva

Ow Lord, you're completely right, we missed that. Your fix is basically right as well, but we are returning nil instead, like in the maxlength component. Could you please send us a pull request with this fix in place? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.