Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated error class for error_notification #586

Closed
tkrotoff opened this issue Jun 2, 2012 · 1 comment
Closed

Duplicated error class for error_notification #586

tkrotoff opened this issue Jun 2, 2012 · 1 comment

Comments

@tkrotoff
Copy link

tkrotoff commented Jun 2, 2012

Easy to replicate:

Go to http://simple-form-bootstrap.plataformatec.com.br/articles/new
Click on 'Create Article' button at the bottom without entering anything inside the fields.
This generates the error message Some errors were found, please take a look: at the top.

The generated HTML is:

<div class="alert alert-error fade in">
  <a class="close" data-dismiss="alert" href="#">×</a>
  <div class="alert alert-error">Some errors were found, please take a look:</div>
</div>

And it should be:

<div class="alert alert-error fade in">
  <a class="close" data-dismiss="alert" href="#">×</a>
  <div>Some errors were found, please take a look:</div>
</div>

See the difference:
Before: before

After: after

@carlosantoniodasilva
Copy link
Member

Just comment out this line from your generator, and it'll work.

We handle that particular case manually in the html in case you want to add the close action in bootstrap's example app. I'm gonna fix it there, thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants