Allow to set the class for collection_wrapper_tag #346

Merged
merged 2 commits into from Nov 5, 2011

3 participants

@mfila

The class can be set with a configuration option and/or on input fields.

@carlosantoniodasilva

Hey mate,

We're fine with this, I'm just wondering whether we should override the default class when one is given as argument, or we should concat both classes together. What do you think?

@mfila

I had the same doubt and I was not able to solve it! :-) Anyway having more flexibility could be useful, so if you want I can modify the code to concat default and given class.

@carlosantoniodasilva

I think it's better to have this flexibility, keeping the "default class" and adding a new one if you send one inline. This keeps things more consistent with the other components.

@mfila

Done!

@rafaelfranca

@carlosantoniodasilva how about this? Can I merge it?

@carlosantoniodasilva

@mfila Thanks for your work on this.

@rafaelfranca Please, go ahead :)

Success! 👍

@rafaelfranca rafaelfranca merged commit 6c283ec into plataformatec:master Nov 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment