Explain how to use ActiveModel nested attributes as per #541 #545

Closed
wants to merge 1 commit into
from

3 participants

@dnagir

I felt the lack of this information around simple_form.

Was caught by the #541 and thought it would be worth to have it in README.

Cheers.

@travisbot

This pull request passes (merged b19db3f into 45ae549).

@rafaelfranca

Thanks but this is not SimpleForm responsibility. SimpleForm only delegates simple_fields_for to Rails fields_for and this is already documented in the Rails method, so I think that we don't need to add the same information to SimpleForm.

@dnagir

I'm pretty sure this would be helpful.

But well, yeah. Up to you :)

@rafaelfranca

For sure it is. But I think that is better explain that simple_fields_for works as fields_for, so the people will look at the fields_for documentation. I'm pushing this change now. Thanks again to this pull request and help us to identify where the documentation can be improved.

@dnagir

That actually makes sense.

I think 2 keywords need to be in the README: "ActiveModel" and "nested" (maybe with the link to fields_for or similar).

Those 2 keywords are important since this is how we scan README :)

@rafaelfranca

Perhaps you can add the content of this pull request in a Wiki page. This will be great too. What did you think?

@dnagir

Will do that.
Cheers.

@rafaelfranca

There is this page that we can improve with ActiveModel information: https://github.com/plataformatec/simple_form/wiki/Nested-Models

@dnagir

Yeah, I should have added it there, but created a new one instead and cross-referenced those.
Is this ok?

@rafaelfranca

Ok. Thank you so much for your help.

@dnagir

No worries.
Thanks you guys too for the great tool and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment