Pre release clean up #7

gmq · 2017-02-03T19:40:19Z

No description provided.

monkeyci · 2017-02-03T19:40:29Z

src/vue-rut.spec.js

+  it('should format value', () => {
+    vm = new Vue({
+      template: '<div>{{superRut | rut}}</div>',
+      data: () => ({


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:30Z

src/vue-rut.spec.js

+    Vue.filter('rut', rutFilter);
+  });
+
+  it('should format value', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:30Z

src/vue-rut.spec.js

+
+describe('Rut Filter', () => {
+  let vm;
+  beforeEach(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:30Z

src/vue-rut.spec.js

+});
+
+describe('Rut Filter', () => {
+  let vm;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-03T19:40:31Z

src/vue-rut.spec.js

+  });
+});
+
+describe('Rut Filter', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:31Z

src/vue-rut.spec.js

+      template: '<div><input v-rut:live name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-03T19:40:31Z

src/vue-rut.spec.js

+    expect(nativeInput.value).toBe('7.618.285-K');
+  });
+
+  it('should always format on blur even if in live mode', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:32Z

src/vue-rut.spec.js

+      template: '<div><input v-rut:live name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-03T19:40:32Z

src/vue-rut.spec.js

+    expect(nativeInput.value).toBe('7618285K');
+  });
+
+  it('should format on keyup if in live mode', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci · 2017-02-03T19:40:32Z

src/vue-rut.spec.js

+      template: '<div><input v-rut name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

gmq · 2017-02-03T19:50:39Z

[4p/5v] Publicar vue-rut en npm

blackjid

Bakan!, lo mergeo....
te hice un mini comentario....

blackjid · 2017-02-03T20:10:54Z

src/vue-rut.spec.js

+  it('should format value', () => {
+    vm = new Vue({
+      template: '<div>{{superRut | rut}}</div>',
+      data: () => ({


aqui el data creo que tiene sentido usar las funciones cortas en vez de arrow funcion, porque dentro de la funcion en data creo que uno prefiere que el this sea la instancia de Vue

Yo se que en este caso no estas usando this, pero como por acostumbrarse...

vm = new Vue({ template: '<div>{{superRut | rut}}</div>', data() { superRut: '7618285K', }), ...

Toda la razón, lo voy a actualizar.

monkeyci · 2017-02-03T20:26:54Z

src/vue-rut.spec.js

+  it('should format value', () => {
+    vm = new Vue({
+      template: '<div>{{superRut | rut}}</div>',
+      data() {


'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-03T20:26:54Z

src/vue-rut.spec.js

+      template: '<div><input v-rut:live name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-03T20:26:54Z

src/vue-rut.spec.js

+      template: '<div><input v-rut name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

blackjid · 2017-02-03T20:43:59Z

aparte de que obedientemente lo cambiaste me encataria saber tu opinion... :)

monkeyci · 2017-02-06T17:44:27Z

src/vue-rut.spec.js

+      template: '<div><input v-rut:live name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-06T17:44:27Z

src/vue-rut.spec.js

+      template: '<div><input v-rut name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-06T17:47:14Z

src/vue-rut.spec.js

+      template: '<div><input v-rut:live name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

monkeyci · 2017-02-06T17:47:14Z

src/vue-rut.spec.js

+      template: '<div><input v-rut name="rut" type="text"></div>',
+    }).$mount();
+
+    const nativeInput = vm.$el.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

gmq added 6 commits February 3, 2017 10:29

chore(): remove dist folder

2126289

feat(): add local eslint rules

cddeda4

fix(): update directive to vue 2

1a16c43

fix(): fix values getting out of sync

b52bb5d

test(): add tests

cdd5009

chore(): update readme

bdb004b

gmq requested a review from blackjid February 3, 2017 19:40

monkeyci reviewed Feb 3, 2017

View reviewed changes

src/vue-rut.spec.js

});

});

describe('Rut Filter', () => {

Copy link

monkeyci Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

monkeyci reviewed Feb 3, 2017

View reviewed changes

blackjid reviewed Feb 3, 2017

View reviewed changes

chore(test): change arrow function to method definition

c05e8d5

monkeyci reviewed Feb 3, 2017

View reviewed changes

blackjid merged commit 198766e into master Feb 3, 2017

monkeyci reviewed Feb 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre release clean up #7

Pre release clean up #7

gmq commented Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

gmq commented Feb 3, 2017

blackjid left a comment

blackjid Feb 3, 2017

gmq Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

monkeyci Feb 3, 2017

blackjid commented Feb 3, 2017

monkeyci Feb 6, 2017

monkeyci Feb 6, 2017

monkeyci Feb 6, 2017

monkeyci Feb 6, 2017

Pre release clean up #7

Pre release clean up #7

Conversation

gmq commented Feb 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmq commented Feb 3, 2017

blackjid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blackjid commented Feb 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment