Bug: No Bare URLs Breakages in Code Block and Smart Typography

[charlesroper]

Describe the Bug

The No Bare URLs rule produces a few unexpected results.

1. When using the Smart Typography extension, quoted URLs get converted. E.g.,

   • ‘https://google.com’ → ‘<https://google.com’>
   • “https://google.com” → “<https://google.com”>

2. URLs within backticks containing text other than just the URL. E.g.,

   • `http --headers --follow --all https://google.com` → `http --headers --follow --all <https://google.com>`

How to Reproduce

1. Install Smart Typography extension and use linter on text with curly quotes and No Bare URLs turned on.

2. Has nothing to do with Smart Typography - just run the linter on a backticked string containing a some text + a url.

Device

• Desktop

Mobile not tested

[pjkaufman]

Thanks for reporting this. I am pretty sure that number 1 is already listed as something that can happen in the linter rule documentation, but I could be wrong. I can see about just ignoring code blocks altogether.

As for smart typography, there currently are no checks for it since it breaks a lot of things to use smart typography. But I can add some checks to the logic for it.

[pjkaufman]

I think I have a fix for this. I am testing it now.

[pjkaufman]

I have a fix and will push it up. Note that it will likely go out with the next release unless I get a couple more bugs fixed. If so, I will try to do a bug fix release tomorrow or Friday.