Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated breadcrumb styles and link styling #379

Merged
merged 6 commits into from
Jun 2, 2020
Merged

feat: updated breadcrumb styles and link styling #379

merged 6 commits into from
Jun 2, 2020

Conversation

jhung
Copy link
Contributor

@jhung jhung commented Jun 2, 2020

Description

This PR updates standalone links and breadcrumbs to match the updated styles for link states.

Steps to test

  1. Go to the Netlify url for this Pull Request.
  2. Check:
    • Link
    • Link List
    • Footer
    • Layouts / Home
    • Layouts / Page
    • Layouts / Term List

Expected behavior:

  • Focus style should be a single border without a background change
  • Active style should be a border with a background change
  • Hover should be a underline change

Related issues

#366 - This PR addresses Link List, but not Accordion.
#243 - Updates standalone links (like headers)

@jhung jhung added the enhancement New feature or request label Jun 2, 2020
@jhung jhung added this to the 1.0.0-beta.3 milestone Jun 2, 2020
@jhung jhung self-assigned this Jun 2, 2020
@netlify
Copy link

netlify bot commented Jun 2, 2020

Deploy preview for pinecone ready!

Built with commit 8bc877f

https://deploy-preview-379--pinecone.netlify.app

@greatislander greatislander changed the title Updated breadcrumb styles and link styling feat: updated breadcrumb styles and link styling Jun 2, 2020
@greatislander greatislander merged commit c2ed697 into platform-coop-toolkit:dev Jun 2, 2020
@jhung jhung mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatislander greatislander greatislander approved these changes

@cherylhjli cherylhjli cherylhjli approved these changes

Assignees

@jhung jhung

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-beta.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jhung @greatislander @cherylhjli