Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on version 1.32.2 x64 #632

Closed
sebasped opened this issue Dec 15, 2018 · 21 comments

Comments

@sebasped
Copy link

commented Dec 15, 2018

Just open a blank and I can't write

2018-12-15-191327_1911x1010_scrot

@Afro-Coder

This comment has been minimized.

Copy link

commented Dec 18, 2018

Same issue, had to use a binary in AUR to make it work

@eliginsburging

This comment has been minimized.

Copy link

commented Dec 18, 2018

I am also experiencing this issue on Manjaro linux using version 1.32.2 x64.

@wzdlc1996

This comment has been minimized.

Copy link

commented Dec 19, 2018

Same issue on Manjaro with version 1.32.2 x64

@DoKel

This comment has been minimized.

Copy link

commented Dec 21, 2018

Atom v1.33, Electron v3.0.13, Chrome v66.0.3359.181, Node v10.2.0 Arch Linux, same issue

@ArenT1981

This comment has been minimized.

Copy link

commented Dec 21, 2018

Same issue for me under Arch Linux running 1.33.1...

@alexmat2on

This comment has been minimized.

Copy link

commented Dec 22, 2018

Another Manjaro user chiming in here, same issue. Atom's developer console displays an error about a missing module pty.node, every time I open a new platformio terminal.

Cannot find module '/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/bin/linux/x64_m64/pty.node' Error: Cannot find module '/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/bin/linux/x64_m64/pty.node'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:602:15)
    at Function.Module._load (internal/modules/cjs/loader.js:528:25)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/lib/pty.js:27:9)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/lib/pty.js:487:3)
    at Module._compile (internal/modules/cjs/loader.js:711:30)
    at Object.value [as .js] (/usr/lib/atom/src/compile-cache.js:235:23)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/index.js:2:18)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/node_modules/pty.js/index.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:711:30)
    at Object.value [as .js] (/usr/lib/atom/src/compile-cache.js:235:23)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (internal/modules/cjs/loader.js:658:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/lib/process.coffee:1:7)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/lib/process.coffee:1:1)
    at Object.<anonymous> (/home/alex/.atom/packages/platformio-ide-terminal/lib/process.coffee:1:1)
    at Module._compile (internal/modules/cjs/loader.js:711:30)
    at Object.value [as .coffee] (/usr/lib/atom/src/compile-cache.js:235:23)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
@Afro-Coder

This comment has been minimized.

Copy link

commented Dec 22, 2018

Compile the latest branch atom-1.33.1 using node v8.9.3 and python2.x

@AndyZhoukh

This comment has been minimized.

Copy link

commented Dec 28, 2018

Me too, atom 1.33.1, electron 3.0.13

@tonimomoni

This comment has been minimized.

Copy link

commented Dec 30, 2018

Same issue on Manjaro 18 with version 1.32.2 x64

@Afro-Coder

This comment has been minimized.

Copy link

commented Jan 6, 2019

@tonimomoni yes this fixes it with the PR in that thread (Sorry if this isn't how it's supposed to be said, still new to GIT and node).
For anyone who will benefit from the steps:

  1. Change the required Lines given in #585
  2. Go to the package directory in $HOME/.atom/packages/platformio-ide-terminal/
  3. Remove/Replace the lines
  4. Run apm install or apm rebuild (atom has its own node version)
  5. Reload atom, load the terminal if it still blinks, do a ctrl+shift+i for dev console and debug.
  6. If nothing works go back to platformio-ide-terminal and remove the node_modules folder and any package-lock.json
  7. Run apm install.
    Enjoy the platformio-ide-terminal features once again!.
@artemtech

This comment has been minimized.

Copy link

commented Jan 11, 2019

1. Change the required Lines given in #585

2. Go to the package directory in $HOME/.atom/packages/platformio-ide-terminal/

3. Remove/Replace the lines

4. Run apm install or apm rebuild (atom has its own node version)

5. Reload atom, load the terminal if it still blinks, do a ctrl+shift+i for dev console and debug.

6. If nothing works go back to platformio-ide-terminal and remove the node_modules folder and any package-lock.json

7. Run apm install.
   Enjoy the platformio-ide-terminal features once again!.

it works on my Arch Linux with Atom 1.33.0 x64,
thanks @leon9923

@sunilkandpal1o1

This comment has been minimized.

Copy link

commented Jan 22, 2019

yeah it works
apm 2.1.3
npm 6.6.0
node 11.7.0 x64
atom 1.34.0
python 2.7.15
git 2.20.1
@leon9923 thanks

@mmans0ur

This comment has been minimized.

Copy link

commented Jan 23, 2019

also worked for me
atom 1.34.0 archlinux
@leon9923 thanks

@the-j0k3r

This comment has been minimized.

Copy link
Collaborator

commented Jan 23, 2019

@ivankravets would you please pin this issue? and also what fixes the problem is #585 please consider merging that, many issues will go away.

@ivankravets

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@leon9923 @mmans0ur @sunilkandpal1o1 do you have GCC in a system?

Actually, there is no sense in changing lines to #585

Run apm install or apm rebuild (atom has its own node version)

It means that you will build own node-pty using your system compiler. Try to uninstall this extension, install again and just

cd ~/.atom/packages/platformio-ide-terminal
apm rebuild

Restart Atom. Does it work without this PR #585 ?

@mmans0ur

This comment has been minimized.

Copy link

commented Jan 24, 2019

I think it is somehow related to archlinux

$atom --version
Atom    : 1.34.0
Electron: 3.1.1
Chrome  : 66.0.3359.181
Node    : 10.2.0
$ gcc --version
gcc (GCC) 8.2.1 20181127

I uninstalled the extension ,reinstalled it and

cd ~/.atom/packages/platformio-ide-terminal
apm rebuild

again result is a blank blinking terminal @ivankravets

@Afro-Coder

This comment has been minimized.

Copy link

commented Jan 24, 2019

@sunilkandpal1o1

This comment has been minimized.

Copy link

commented Jan 25, 2019

@ivankravets yes I have gcc installed
I tried the steps you mentioned, again this results in a blinking cursor
changing those lines seems like the only solution right now.
I am on Arch linux if that helps as @mmans0ur mentioned it might be related to archlinux

@ivankravets

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

@sebasped

This comment has been minimized.

Copy link
Author

commented Jan 25, 2019

@dustinwilson

This comment has been minimized.

Copy link

commented Jul 5, 2019

I was having this issue again except with 2.9.1 on Manjaro Linux. I tried building atom-editor-bin from AUR. While platformio-ide-terminal works in it the older version of electron it uses has issues with the menu bar not accepting the theme's text colors, leaving it unreadable. So, I went looking for a solution in hopes of getting it to work on the official package. I stumbled upon this issue and did a lot of the things above to no avail. I ended up finding a solution, so I'm leaving it here for anyone else still having this issue to discover:

npm -g electron-rebuild
cd ~/.atom/packages/platformio-ide-terminal
electron-rebuild -v 4.2.6 -f

After I do that platformio-ide-terminal works just fine. Took me quite a while to find this as I've never done any development with electron before myself. I did notice when I was digging through stuff that the node-pty-prebuilt package on npm is quite outdated, not having published anything to npm in a year. The node-pty package has been regularly published -- including some security-related updates. I don't know if that is going to eventually cause trouble in the future considering the official Arch package patches atom to use a newer shared version of electron, but I thought I'd point that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.