Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent commit breaks build #2268

Closed
mxtommy opened this issue Mar 31, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mxtommy
Copy link

commented Mar 31, 2019

What kind of issue is this?

  • PlatformIO Core.
    If you’ve found a bug, please provide an information below.

Configuration

Operating system: Windows
PlatformIO Version (platformio --version): 3.6.6

Description of problem

Commit d9e6111 lines 164-170 in platformio/builder/tools/piomisc.py removes already declared prototypes. However if there are no prototypes left in list, line 173 which references a specific index (0), causes build to fail with

IndexError: list index out of range

If I comment out the new lines (164-170 of piomisc.py) project compiles fine.

Steps to Reproduce

  1. Have .ino file
  2. Forward declare all functions
  3. Profit? :)

Actual Results

Build fails converting the ino to cpp

Expected Results

It should work :)

Source file to reproduce issue:

void setup();
void loop();

void setup() {
  // put your setup code here, to run once:
}

void loop() {
  // put your main code here, to run repeatedly:
}

NOTE, must be Ino file, not cpp :)

Additional info

@mxtommy mxtommy changed the title Recent commit brakes build Recent commit breaks build Mar 31, 2019

@ivankravets ivankravets added the bug label Apr 1, 2019

@ivankravets ivankravets added this to the 3.6.7 milestone Apr 1, 2019

@ivankravets

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks! Please re-test with pio upgrade --dev.

@ivankravets ivankravets referenced this issue Apr 23, 2019

Closed

platformio 3.6.7 #39182

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.