Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cache expires too fast #2559

Closed
mcspr opened this issue May 26, 2019 · 2 comments

Comments

2 participants
@mcspr
Copy link

commented May 26, 2019

Running platformio from develop branch.

In platformio.ini

lib_deps =
    ArduinoJson@5.13.4

Watching 2 files:

~/.platformio/.cache/65/8154dacc963fd98df885ac5d9cc5c265
~/.platformio/.cache/7e/ba586a56b4024a92728654afd0862c7e

Running basic empty project with d1_mini board:

$ pio run
$ rm -r .pio/libdeps/<env>/ArduinoJson_ID64
$ ...wait some time...
$ pio run

Package archive and fname from cache are deleted and redownloaded after 1 minute.
Observed either using prints in ContentCache or inotifywait -mr ~/.platformio/.cache (preemptively cleaned, to minimize cache changes)

Looking at expiration time shortcuts:

tdmap = {"s": 1, "m": 60, "h": 3600, "d": 86400}

This is 1 minute instead of intended 30d:

FILE_CACHE_VALID = "1m" # 1 month

Shouldn't expiration time be "never" for these, since urls are (evidently) unique per version? Still allowing manual clean-up (adding second time field, "created_at"?)
Or requests itself can cache things based on etag, or pass it along.

Originally posted by @mcspr in #1696 (comment)
edit: pio version, typo. and sorry no template, this was opened via "reference in a new issue"

@ivankravets

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Thank you so much for the report! Please re-test with pio upgrade --dev.

@ivankravets ivankravets modified the milestones: 3.6.8, 4.0 May 27, 2019

@ivankravets ivankravets added this to Done in PlatformIO 4.0 May 27, 2019

@mcspr

This comment has been minimized.

Copy link
Author

commented May 27, 2019

It works, thanks!

@ivankravets ivankravets added this to Done in PlatformIO 4.0 May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.