Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing tool-cppcheck version via platform_packages is ignored #3798

Closed
maxgerhardt opened this issue Jan 9, 2021 · 1 comment
Closed

Comments

@maxgerhardt
Copy link
Contributor

maxgerhardt commented Jan 9, 2021

What kind of issue is this?

  • [X ] PlatformIO Core.
    If you’ve found a bug, please provide an information below.

Configuration

Operating system: Win x64

PlatformIO Version (platformio --version): PlatformIO Core, version 5.0.5a1

Description of problem

In regards to the same issue and linked reproduction project as posted in #3797, I've tried to make PIO use different versions of tool-cppcheck in regards to the uploaded versions (https://bintray.com/platformio/tool-packages/tool-cppcheck-windows_amd64#files).

Thus I e.g. added

platform_packages = tool-cppcheck@1.210.0

in the platformio.ini.

After a pio run, this does cause that version to be downloaded to tool-cppcheck@1.210.0 next to tool-cppcheck, however it is unused when a check command is executed, as in pio check --skip-packages.

Taskamanger without the addition above (should use latest tool-cppcheck, and it does)

grafik

With additions above

grafik

still uses newer version.

Steps to Reproduce

  1. Use reproduction project as in Inclusion of ArduinoJSON causes cppcheck to not recognize a call to a function #3797
  2. Modify platformio.ini as stated above
  3. Execute pio run once
  4. Execute pio check --skip-packages, while switching to the task manager directly after that, to see in the process details which .exe is actually executed

Actual Results

Latest tool-cppcheck path is used, and not the 1.210.0 one, as stated in the platformio.ini.

Expected Results

Package change for tool-cppcheck stated in platformio.ini is respected.

If problems with PlatformIO Build System:

Files see as linked above

Additional info

@ivankravets ivankravets added this to the 5.0.5 milestone Jan 9, 2021
@ivankravets ivankravets modified the milestones: 5.0.5, 5.1.0 Jan 19, 2021
@ivankravets ivankravets modified the milestones: 5.2.0, 5.3.0 Mar 15, 2021
@ivankravets ivankravets modified the milestones: 5.4, Backlog Feb 9, 2022
@ivankravets ivankravets modified the milestones: Backlog, 5.3.0 Mar 31, 2022
@ivankravets ivankravets self-assigned this Apr 1, 2022
@ivankravets
Copy link
Member

Thanks for the report! Please re-test with pio upgrade --dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants