Changing tool-cppcheck version via platform_packages is ignored

[maxgerhardt]

What kind of issue is this?

• [X ] PlatformIO Core.
  If you’ve found a bug, please provide an information below.

---

Configuration

Operating system: Win x64

PlatformIO Version (platformio --version): PlatformIO Core, version 5.0.5a1

Description of problem

In regards to the same issue and linked reproduction project as posted in #3797, I've tried to make PIO use different versions of tool-cppcheck in regards to the uploaded versions (https://bintray.com/platformio/tool-packages/tool-cppcheck-windows_amd64#files).

Thus I e.g. added

platform_packages = tool-cppcheck@1.210.0

in the platformio.ini.

After a pio run, this does cause that version to be downloaded to tool-cppcheck@1.210.0 next to tool-cppcheck, however it is unused when a check command is executed, as in pio check --skip-packages.

Taskamanger without the addition above (should use latest tool-cppcheck, and it does)

With additions above

still uses newer version.

Steps to Reproduce

1. Use reproduction project as in Inclusion of ArduinoJSON causes cppcheck to not recognize a call to a function #3797
2. Modify platformio.ini as stated above
3. Execute pio run once
4. Execute pio check --skip-packages, while switching to the task manager directly after that, to see in the process details which .exe is actually executed

Actual Results

Latest tool-cppcheck path is used, and not the 1.210.0 one, as stated in the platformio.ini.

Expected Results

Package change for tool-cppcheck stated in platformio.ini is respected.

If problems with PlatformIO Build System:

Files see as linked above

Additional info

[ivankravets]

Thanks for the report! Please re-test with pio upgrade --dev.