Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libArchive option is being ignored in 6.1.1 #4351

Closed
1 of 5 tasks
crespum opened this issue Jul 12, 2022 · 7 comments
Closed
1 of 5 tasks

libArchive option is being ignored in 6.1.1 #4351

crespum opened this issue Jul 12, 2022 · 7 comments
Labels
bug build system ldf Library Dependency Finder
Milestone

Comments

@crespum
Copy link

crespum commented Jul 12, 2022

What kind of issue is this?

  • Question.
    This issue tracker is not the place for questions. If you want to ask how to do something,
    or to understand why something isn't working the way you expect it to,
    use Community Forums or Premium Support

  • PlatformIO IDE.
    All issues related to PlatformIO IDE should be reported to appropriate repository:
    PlatformIO IDE for Atom or
    PlatformIO IDE for VSCode

  • Development Platform or Board.
    All issues (building, uploading, adding new boards, etc.) related to PlatformIO development platforms
    should be reported to appropriate repository related to your hardware
    https://github.com/topics/platformio-platform

  • Feature Request.
    Start by telling us what problem you’re trying to solve. Often a solution
    already exists! Don’t send pull requests to implement new features without first getting our
    support. Sometimes we leave features out on purpose to keep the project small.

  • PlatformIO Core.
    If you’ve found a bug, please provide an information below.

You can erase any parts of this template not applicable to your Issue.


Configuration

Operating system: Linux (Fedora 35)

PlatformIO Version (platformio --version): 6.1.1

Description of problem

We've got a big project with many libraries under lib directory. Each of these libraries contains a "libArchive": false, option inside its corresponding library.json. Up to version 6.1.0, this used to work as documented: the library was not compiled into a .a but every source file was compiled into an object to be linked in the last build step.

Since version 6.1.1 this option seems to be ignored and the libraries are compiled to intermediate .a files. I suspect it has to do with this commit.

Steps to Reproduce

  1. Clone https://github.com/crespum/arduino-blink-core-bug
  2. Build with Core 6.1.0 and save the output
  3. Build with Core 6.1.1 and save the output
  4. Compare both outputs and see an unexpected libtest_lib.a in 6.1.1 (this is the linker output taken in my setup)
@ivankravets ivankravets added bug ldf Library Dependency Finder build system labels Jul 12, 2022
@ivankravets ivankravets added this to the 6.1.2 milestone Jul 12, 2022
@ivankravets
Copy link
Member

Sorry for the issue and thanks for the report! Could you re-test with pio upgrade --dev? If it works for you, we will plan a hotfix release.

@ivankravets
Copy link
Member

Resolved in 83bb661

@crespum
Copy link
Author

crespum commented Jul 12, 2022

Thanks so much! That seems to fix the issue. I can only compare the build results right now, but I'll test in the hardware tomorrow morning.

@crespum
Copy link
Author

crespum commented Jul 13, 2022

I can confirm now that the firmware seems to work fine too. Again, thank you so much.

@ivankravets
Copy link
Member

Thanks for your feedback! 🙏

@nerdyscout
Copy link

using v6.1.4b2 it feels like I just run into same issue defining lib_archive = no in platformio.ini
could it be this has been fixed only for library.json?

@ivankravets
Copy link
Member

@nerdyscout could you provide a simple PlatformIO project to reproduce your issue? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build system ldf Library Dependency Finder
Projects
None yet
Development

No branches or pull requests

3 participants