Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum version of Python is 3.6 but pio package publish requires 3.7 #4352

Closed
1 task done
nomis opened this issue Jul 12, 2022 · 2 comments
Closed
1 task done

Minimum version of Python is 3.6 but pio package publish requires 3.7 #4352

nomis opened this issue Jul 12, 2022 · 2 comments

Comments

@nomis
Copy link
Contributor

nomis commented Jul 12, 2022

What kind of issue is this?

  • PlatformIO Core.
    If you’ve found a bug, please provide an information below.

Configuration

Operating system: Ubuntu 18.04 LTS

PlatformIO Version (platformio --version): PlatformIO Core, version 6.0.2

Description of problem

The HISTORY.rst file claims that PlatformIO's minimum Python version is 3.6 but pio package publish requires 3.7 because it uses str.isascii().

(Ideally the Python code should be automatically checked to determine if it can be run on older versions of Python.)

Steps to Reproduce

  1. Run pio package publish with python 3.6

Actual Results

...
  File "/home/simon/.local/lib/python3.6/site-packages/platformio/package/commands/publish.py", line 116, in package_publish_cmd
    check_archive_file_names(archive_path)
  File "/home/simon/.local/lib/python3.6/site-packages/platformio/package/commands/publish.py", line 152, in check_archive_file_names
    if not name.isascii():
AttributeError: 'str' object has no attribute 'isascii'

Expected Results

Package is published

@ivankravets
Copy link
Member

Thanks for the report! Please re-test with pio upgrade --dev.

@ivankravets
Copy link
Member

Resolved in 4278574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants