Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs scripts/ directory to the global namespace #4458

Closed
1 task done
mcepl opened this issue Nov 12, 2022 · 1 comment
Closed
1 task done

Installs scripts/ directory to the global namespace #4458

mcepl opened this issue Nov 12, 2022 · 1 comment
Milestone

Comments

@mcepl
Copy link

mcepl commented Nov 12, 2022

What kind of issue is this?

  • PlatformIO Core.
    If you’ve found a bug, please provide an information below.

Configuration

Operating system: Linux, openSUSE/Tumbleweed

PlatformIO Version (platformio --version): 6.1.5

Description of problem

When packaging platformIO-core for openSUSE, I have discovered that the package’s install script creates and populates purelib/scripts directory. That sounds wrong to me, shouldn’t it put these scripts as a subdirectory of the platformio package?

Steps to Reproduce

  1. python3 setup.py install

Actual Results

The script installs two subdirectories in purelib: platformio/ and scripts/.

Expected Results

It should install just one subdirectory, not using another name in the global namespace and especially not with so generic symbol.

If problems with PlatformIO Build System:

The content of platformio.ini:
none

Complete build log for details of packages used and steps taken to reproduce.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Nov 13, 2022
https://build.opensuse.org/request/show/1035453
by user mcepl + dimstar_suse
- Switch to wheel build/install, move scripts/ directory to the
  packages's namespace (see gh#platformio/platformio-core#4458).
- Add python-platformio.rpmlintrc to avoid false positives.
- Update to versino 6.1.5
  * Added a new enable_proxy_strict_ssl setting to disable the proxy server certificate verification (issue #4432)
  * Documented PlatformIO Core Proxy Configuration
  * Speeded up device port finder by avoiding loading board HWIDs from development platforms
  * Improved caching of build metadata in debug mode
  * Fixed an issue when pio pkg install --storage-dir command requires PlatformIO project (issue #4410)
- Update to version 6.1.4 (2022-08-12)
  Added support for accepting the original FileNode environment in a “callback” function when using Build Middlewares (pull #4380)
@ivankravets ivankravets added this to the 6.1.6 milestone Nov 18, 2022
@ivankravets
Copy link
Member

Thanks for the PR! Please re-test with pio upgrade --dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants