New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor platform build scripts #528

Closed
ivankravets opened this Issue Feb 21, 2016 · 18 comments

Comments

Projects
None yet
3 participants
@ivankravets
Member

ivankravets commented Feb 21, 2016

Need to refactor all build scripts and put base flags to appropriate SCOPES. More details http://docs.platformio.org/en/latest/projectconf.html#build-flags

User should have ability to pass own build flags and override base settings. In this case, user's flags should follow after "base flags".

@ivankravets ivankravets added this to the 2.8.5 milestone Feb 21, 2016

@ivankravets

This comment has been minimized.

Member

ivankravets commented Feb 21, 2016

Related issue platformio/platformio-atom-ide#54 where build_flags = -Wno-comment doesn't work.

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

I tried to use build_flags = -Wno-comment in platformio.ini, but it doesn't work.

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

@sstaub do you use the latest development version? platformio --version

http://docs.platformio.org/en/latest/installation.html#development-version

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

The IDE is v1.04

Am 01.03.2016 um 10:25 schrieb Ivan Kravets notifications@github.com:

@sstaub https://github.com/sstaub do you use the latest development version? platformio --version


Reply to this email directly or view it on GitHub #528 (comment).

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

Sorry, version of platformio is 2.7.1

Am 01.03.2016 um 10:25 schrieb Ivan Kravets notifications@github.com:

platformio --version

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

@sstaub Gear Icon(Settings) on the PlatformIO Toolbar > Packages > platformio-ide > Settings > Use development version of PlatformIO

P.S: Don't forget to uncheck it when 2.8.5 will be released.

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

It did the check in the settings long times ago. But i don’t know which version is now currently installed:

Am 01.03.2016 um 10:58 schrieb Ivan Kravets notifications@github.com:

@sstaub https://github.com/sstaub Gear Icon(Settings) on the PlatformIO Toolbar > Packages > platformio-ide > Settings > Use development version of PlatformIO

P.S: Don't forget to uncheck it when 2.8.5 will be released.


Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Then Menu > PlatformIO > Upgrade PlatformIO.

It will install the latest development version.

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

The problem is that I do upgrading (see screenshot), but when I ask which version installed
with platformio —version it says 2.7.1

Am 01.03.2016 um 11:17 schrieb Ivan Kravets notifications@github.com:

Then Menu > PlatformIO > Upgrade PlatformIO.

It will install the latest development version.


Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Open system Terminal (not in IDE), run pip uninstall platformio. Restart IDE

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

No changes.

Am 01.03.2016 um 11:23 schrieb Ivan Kravets notifications@github.com:

Open system Terminal (not in IDE), run pip uninstall platformio. Restart IDE


Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Which is your OS?

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

MacBookPro Yosemite 10.10.5

Am 01.03.2016 um 11:28 schrieb Ivan Kravets notifications@github.com:

Which is your OS?


Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Give me please an output:

  1. Open terminal in IDE: which platformio
  2. Open System OS terminal: which platformio
@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

Am 01.03.2016 um 11:31 schrieb Ivan Kravets notifications@github.com:

Give me please an output:

  1. Open terminal in IDE: which platformio

stefans-mbp-3:OSCwing sstaub$ stefans-mbp-3:~ sstaub$ which platformio
bash: stefans-mbp-3:~: command not found
stefans-mbp-3:OSCwing sstaub$ /usr/local/bin/platformio
Usage: platformio [OPTIONS] COMMAND [ARGS]...

  1. Open System OS terminal: which platformio

stefans-mbp-3:~ sstaub$ which platformio
/usr/local/bin/platformio
stefans-mbp-3:~ sstaub$

Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Hm... And pip list in the both Terminals (IDE + OS)

@sstaub

This comment has been minimized.

sstaub commented Mar 1, 2016

says platformio (2.7.1) in both terminals

Am 01.03.2016 um 11:38 schrieb Ivan Kravets notifications@github.com:

Hm... And pip list in the both Terminals (IDE + OS)


Reply to this email directly or view it on GitHub #528 (comment).

@ivankravets

This comment has been minimized.

Member

ivankravets commented Mar 1, 2016

Please mail me@ikravets.com directly.

ivankravets added a commit that referenced this issue Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment