integer arguments in build_flags are missing

[Palatis]

I'm starting a new platform, and am trying to write my board.json.

I observed that arguments starts with [0-9]+ are missing in pio action command line.
for example,

{
  "build": [
    "extra_flags": "-DN79E85X -DN79E855 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_N79E85X --iram-size 256 --xram-size 256 --code-size 16384 --stack-size 128",
    ...
  ],
  ...
}

and pio run -v outputs something like:

sdcc -o .pioenvs/mcs51/src/ADC.rel -c --std-sdcc11 --opt-code-size --peep-asm --peep-return -mmcs51 --iram-size --xram-size --code-size --stack-size -DF_CPU=22118400L -DPLATFORMIO=030100 -DN79E85X -DN79E855 -DNAKED_ARCH_MCS51 -DNAKED_MCS51_N79E85X -I/home/palatis/.platformio/packages/framework-nakedmcs51/cores/naked -I/home/palatis/.platformio/packages/framework-nakedmcs51/variants/n79e85x -Isrc src/ADC.c

all the integer values from build.extra_flags are gone into the void.

and this doesn't work for platformio.ini either:

[env:myboard]
build_flags = --iram-size 256 --xram-size 256 --code-size 16384 --stack-size 128

same output from pio run -v

[ivankravets]

Could you try --iram-size=256 --xram-size=256?

[Palatis]

I tried already, and sdcc doesn't understand that.

actually i tried

build_flags = --iram-size 256 ; 256 missing
build_flags = --iram-size "256" ; 256 missing
build_flags = --iram-size \"256\" ; 256 missing
build_flags = "--iram-size 256" ; shell treat this as one argument and sdcc refuse to run.
build_flags = --iram-size=256 ; sdcc doesn't understand that

none of them work.

[ivankravets]

That was your solution?

[ivankravets]

The problem here that we use SCons ParseFlags. Search for "env.ParseFlags(".

I see only 1 solution here. Create a new field in board manifest, like "build.extra_flags_" and put here these flags. Then, within main.py in platform build script you will be able to put these flags where do you want.

env.Append(
...
)

[Palatis]

current solution is more like a "workaround".

I add

  "build": {
    "iram_size": 256,
    "xram_size": 256,
    "code_size": 4096,
    "heap_size": 128
  }

in board.json and parse them with builder/main.py.
https://github.com/Palatis/platform-mcs51/blob/master/builder/main.py#L98
https://github.com/Palatis/platform-mcs51/blob/master/boards/n79e855.json

but the problem is, I haven't found a way to let the user specify these in platformio.ini.

[ivankravets]

Yes, you are right. However, use 1 field and make array

  "build": 
  {
      "extra_flags_": [
        "iram_size", "256",
        "xram_size", "256"
   ]
}

env.Append(LINKFLAGS=env.BoardConfig().get("build.extra_flags_"))

[Palatis]

will give it a try when i got time.
got other stuff to work on.