New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'platformio run' should have non-zero exit code on compilation or upload failure #81

Closed
aphelps opened this Issue Feb 17, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@aphelps

aphelps commented Feb 17, 2015

It looks like 'platformio run' has a retcode of 0 even when it fails, for scripting purposes it really should return a non-zero value:

amp@AMP-MBP-home:~/Dropbox/Arduino/HMTL/platformio/HMTL_Module [master]$ platformio run
[Mon Feb 16 19:59:08 2015] Processing arduino_nano (platform: atmelavr, build_flags: -DDISABLE_MPR121, board: nanoatmega328, framework: arduino)
----------------------------------------------------------------------------------------------------------------------------------------------------------
avr-g++ -o .pioenvs/arduino_nano/src/HMTL_Module.o -c -fno-exceptions -fno-threadsafe-statics -g -Os -ffunction-sections -fdata-sections -MMD -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO_ARCH_AVR -DARDUINO_AVR_NANO -DDISABLE_MPR121 -DARDUINO=158 -I.pioenvs/arduino_nano/FrameworkArduino -I.pioenvs/arduino_nano/FrameworkArduinoVariant -I.pioenvs/arduino_nano/EEPROM -I.pioenvs/arduino_nano/RS485_non_blocking -I.pioenvs/arduino_nano/SoftwareSerial -I.pioenvs/arduino_nano/SPI -I.pioenvs/arduino_nano/FastLED -I.pioenvs/arduino_nano/Wire -I.pioenvs/arduino_nano/Debug -I.pioenvs/arduino_nano/GeneralUtils -I.pioenvs/arduino_nano/EEPromUtils -I.pioenvs/arduino_nano/HMTLTypes -I.pioenvs/arduino_nano/PixelUtil -I.pioenvs/arduino_nano/Socket -I.pioenvs/arduino_nano/RS485Utils -I.pioenvs/arduino_nano/MPR121 -I.pioenvs/arduino_nano/HMTLMessaging -I.pioenvs/arduino_nano/HMTLprotocol -I.pioenvs/arduino_nano/Wire/utility .pioenvs/arduino_nano/src/HMTL_Module.cpp
HMTL_Module.ino:578:1: error: 'XXX' does not name a type
scons: *** [.pioenvs/arduino_nano/src/HMTL_Module.o] Error 1
============================================================== [ ERROR ] Took 0.67 seconds ==============================================================
amp@AMP-MBP-home:~/Dropbox/Arduino/HMTL/platformio/HMTL_Module [master]$ echo $?
0

@ivankravets ivankravets self-assigned this Feb 17, 2015

@ivankravets ivankravets added this to the 1.0.0 milestone Feb 17, 2015

@ivankravets ivankravets added the bug label Feb 17, 2015

@ivankravets

This comment has been minimized.

Member

ivankravets commented Feb 19, 2015

Thanks a lot for report! 👍 Fixed in 2d53d21

Please re-test it and platformio update packages. I hope, we are at the final line before release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment