Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove line-buffering from programmer #856

Closed
eric-wieser opened this issue Dec 21, 2016 · 5 comments

Comments

2 participants
@eric-wieser
Copy link

commented Dec 21, 2016

Configuration

Operating system: Windows 10 x64

PlatformIO Version (platformio --version): 3.2.1

Description of problem

When the program run by platformio run --target upload emits progressbars, these are linebuffered, and therefore only the final result is visible

Steps to Reproduce

  1. platformio init --board mega_pic32
  2. Write some basic code
  3. platformio run --target upload

Actual Results

Progress bars are emitted once complete, and not during execution. Upload is still successfull

Uploading .pioenvs\mega_pic32\firmware.hex
Programmer for Microchip PIC32 microcontrollers, Version 2.1.24
Copyright: (C) 2011-2015 Serge Vakulenko
Adapter: STK500v2 Bootloader
Program area: 1d000000-1d1fffff
Processor: Bootloader
Flash memory: 2048 kbytes
Boot memory: 80 kbytes
Data: 56364 bytes
Erase: done
Program flash: ########################################################## done
Verify flash: ######################################################### done
Program rate: 2048 bytes per second

Expected Results

Output is duplicated through platformio character-by-character

@eric-wieser eric-wieser changed the title Remove line-buffering from programmer Feature request: Remove line-buffering from programmer Dec 21, 2016

@eric-wieser

This comment has been minimized.

Copy link
Author

commented Dec 21, 2016

Hmm, this actually seems to be

@eric-wieser

This comment has been minimized.

Copy link
Author

commented Dec 21, 2016

@ivankravets

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

This issue is related to https://github.com/platformio/platformio-core/blob/develop/platformio/util.py#L87

I played with it in a previous year. I don't remember why I decided to save it without changes.

@eric-wieser

This comment has been minimized.

Copy link
Author

commented Dec 21, 2016

Seems to me that parsing output for error messages, yet allowing rewritable output, are behaviours that are sort of at odds with each other, and maybe need some platform-specific config to toggle

@eric-wieser

This comment has been minimized.

Copy link
Author

commented Dec 21, 2016

Unless we did something unusual like printing \r and repeating the line in red if enough characters for an error are found

@ivankravets ivankravets added this to the 4.0 milestone Jan 8, 2019

@ivankravets ivankravets added this to To do in PlatformIO 4.0 Mar 23, 2019

@ivankravets ivankravets moved this from To do to In progress in PlatformIO 4.0 May 9, 2019

@ivankravets ivankravets moved this from In progress to To do in PlatformIO 4.0 May 9, 2019

@ivankravets ivankravets moved this from To do to In progress in PlatformIO 4.0 May 16, 2019

@ivankravets ivankravets moved this from In progress to Done in PlatformIO 4.0 May 17, 2019

@ivankravets ivankravets added this to Done in PlatformIO 4.0 May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.