Skip to content

unity.py: fixing whitespace issue when running tests with -Wpedantic - #4671

Closed
MacDada wants to merge 1 commit into
platformio:developfrom
MacDada:unity_pedantic
Closed

unity.py: fixing whitespace issue when running tests with -Wpedantic#4671
MacDada wants to merge 1 commit into
platformio:developfrom
MacDada:unity_pedantic

Conversation

@MacDada

@MacDada MacDada commented Jun 18, 2023

Copy link
Copy Markdown
Contributor
pio test

[…]

Library Manager: Installing throwtheswitch/Unity @ ^2.5.2
Unpacking  [####################################]  100%
Library Manager: Unity@2.5.2 has been installed!
.pio/build/native/unity_config/unity_config.c:44:5: warning: no newline at end of file [-Wnewline-eof]

    ^
1 warning generated.
Testing...

There used to be a blank line with 4 spaces in the generated code -> strip(' ') removes the spaces, leaving the blank line intact.

…` flag

```
Library Manager: Installing throwtheswitch/Unity @ ^2.5.2
Unpacking  [####################################]  100%
Library Manager: Unity@2.5.2 has been installed!
.pio/build/native/unity_config/unity_config.c:44:5: warning: no newline at end of file [-Wnewline-eof]

    ^
1 warning generated.
Testing...
```

In the generated code, there used to be a blank line with 4 spaces -> `strip(' ')` removes the spaces, leaving the blank line intact.
@MacDada

MacDada commented Jun 18, 2023

Copy link
Copy Markdown
Contributor Author

I don't think the build issues are related to the PR.

@ivankravets

Copy link
Copy Markdown
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants