Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for templated methods in InoToCPPConverter #858

Merged
merged 2 commits into from Dec 22, 2016

Conversation

@xoseperez
Copy link
Contributor

xoseperez commented Dec 21, 2016

The InoToCPPConverter class does not match templated methods, like for instance this one:

template<typename T> bool setSetting(const String& key, T value) {
    return Embedis::set(key, String(value));
}
@ivankravets
Copy link
Member

ivankravets commented Dec 21, 2016

Hi,

Thank you! Could you provide a test for this PR?

You can run a test using py.test -v -s tests/test_ino2cpp.py command from a root of project.

@ivankravets
Copy link
Member

ivankravets commented Dec 21, 2016

@ivankravets ivankravets added this to the 3.2.2 milestone Dec 21, 2016
@xoseperez
Copy link
Contributor Author

xoseperez commented Dec 21, 2016

Can't sign the CLA. It says "We're sorry, but something went wrong"...

@ivankravets
Copy link
Member

ivankravets commented Dec 22, 2016

@xoseperez
Copy link
Contributor Author

xoseperez commented Dec 22, 2016

Done, CLA signed.

@ivankravets ivankravets merged commit 1a4c5df into platformio:develop Dec 22, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details
@ivankravets
Copy link
Member

ivankravets commented Dec 22, 2016

Thanks a lot!

@eric-wieser
Copy link

eric-wieser commented Dec 23, 2016

I don't think templated methods like that in ino files work properly in the Arduino ide either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.