New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for templated methods in InoToCPPConverter #858

Merged
merged 2 commits into from Dec 22, 2016

Conversation

Projects
None yet
3 participants
@xoseperez
Contributor

xoseperez commented Dec 21, 2016

The InoToCPPConverter class does not match templated methods, like for instance this one:

template<typename T> bool setSetting(const String& key, T value) {
    return Embedis::set(key, String(value));
}
@ivankravets

This comment has been minimized.

Show comment
Hide comment
@ivankravets

ivankravets Dec 21, 2016

Member

Hi,

Thank you! Could you provide a test for this PR?

You can run a test using py.test -v -s tests/test_ino2cpp.py command from a root of project.

Member

ivankravets commented Dec 21, 2016

Hi,

Thank you! Could you provide a test for this PR?

You can run a test using py.test -v -s tests/test_ino2cpp.py command from a root of project.

@ivankravets

This comment has been minimized.

Show comment
Hide comment
@ivankravets
Member

ivankravets commented Dec 21, 2016

@ivankravets ivankravets added this to the 3.2.2 milestone Dec 21, 2016

@xoseperez

This comment has been minimized.

Show comment
Hide comment
@xoseperez

xoseperez Dec 21, 2016

Contributor

Can't sign the CLA. It says "We're sorry, but something went wrong"...

Contributor

xoseperez commented Dec 21, 2016

Can't sign the CLA. It says "We're sorry, but something went wrong"...

@ivankravets

This comment has been minimized.

Show comment
Hide comment
@xoseperez

This comment has been minimized.

Show comment
Hide comment
@xoseperez

xoseperez Dec 22, 2016

Contributor

Done, CLA signed.

Contributor

xoseperez commented Dec 22, 2016

Done, CLA signed.

@ivankravets ivankravets merged commit 1a4c5df into platformio:develop Dec 22, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details
@ivankravets

This comment has been minimized.

Show comment
Hide comment
@ivankravets

ivankravets Dec 22, 2016

Member

Thanks a lot!

Member

ivankravets commented Dec 22, 2016

Thanks a lot!

@eric-wieser

This comment has been minimized.

Show comment
Hide comment
@eric-wieser

eric-wieser Dec 23, 2016

I don't think templated methods like that in ino files work properly in the Arduino ide either...

eric-wieser commented Dec 23, 2016

I don't think templated methods like that in ino files work properly in the Arduino ide either...

@ivankravets ivankravets referenced this pull request Mar 27, 2017

Closed

platformio 3.3.0 #11647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment