Skip to content

Remove need for machine to have a valid hostname in IdGenerator #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Remove need for machine to have a valid hostname in IdGenerator #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions application/shared-kernel/SharedKernel/StronglyTypedIds/IdGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Net;
using System.Net.NetworkInformation;
using System.Net.Sockets;

namespace PlatformPlatform.SharedKernel.StronglyTypedIds;
Expand Down Expand Up @@ -33,12 +33,28 @@ public static long NewId()
/// </summary>
private static int GetUniqueGeneratorIdFromIpAddress()
{
var host = Dns.GetHostEntry(Dns.GetHostName());
const string noNetworkAdapters = "No network adapters with an IPv4 address in the system. IdGenerator is meant to create unique IDs across multiple machines, and requires an IP address to do so.";
var ipAddress = Array.Find(host.AddressList, ip => ip.AddressFamily == AddressFamily.InterNetwork)
?? throw new InvalidOperationException(noNetworkAdapters);

var lastSegment = ipAddress.ToString().Split('.')[3];
return int.Parse(lastSegment);
var networkInterfaces = NetworkInterface.GetAllNetworkInterfaces()
.Where(ni => ni.OperationalStatus == OperationalStatus.Up &&
ni.NetworkInterfaceType != NetworkInterfaceType.Loopback &&
ni.NetworkInterfaceType != NetworkInterfaceType.Tunnel
)
.ToArray();

foreach (var networkInterface in networkInterfaces)
{
var properties = networkInterface.GetIPProperties();
var ipv4Address = properties.UnicastAddresses
.FirstOrDefault(addr => addr.Address.AddressFamily == AddressFamily.InterNetwork);

if (ipv4Address is not null)
{
var lastSegment = ipv4Address.Address.ToString().Split('.')[3];
return int.Parse(lastSegment);
}
}

throw new InvalidOperationException(noNetworkAdapters);
}
}