Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java GA #1053

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@OriPekelman
Copy link
Contributor

commented Mar 19, 2019

No description provided.

OriPekelman added some commits Mar 19, 2019

Show resolved Hide resolved src/languages/java.md Outdated
You can find an example Tomcat based application using Maven here: https://github.com/platformsh/platformsh-example-java-tomcat-maven and a Spring Boot one using gradle over here: https://github.com/platformsh/platformsh-example-java-spring-gradle

## Building and running the application
Note that there will still be an Nginx proxy server sitting in front of your application. If desired, certain paths may be served directly by Nginx without hitting your application (for static files, primarily) or you may route all requests to the Java application unconditionally, as in the example above.

This comment has been minimized.

Copy link
@ralt

ralt Mar 19, 2019

Contributor

Which example above?


## Supported versions

We support both the Oracle JVM and the Open JDK but we strongly suggest you use the Open JDK as support for the Oracle JVM may be dropped in the future if they continue with their licensing shenanigans.

This comment has been minimized.

Copy link
@Crell

Crell Mar 20, 2019

Contributor

That's really not the way we should phrase it. It may be accurate but it's kinda petulant in the documentation.


## Running Tomcat

You can find an example Tomcat based application using Maven here: https://github.com/platformsh/platformsh-example-java-tomcat-maven and a Spring Boot one using gradle over here: https://github.com/platformsh/platformsh-example-java-spring-gradle

This comment has been minimized.

Copy link
@Crell

Crell Mar 20, 2019

Contributor

We don't inline the links anywhere else. They should be contextual words in the paragraph, or in a bulleted list.

As these setups are a bit tricky, they need more inline documentation here unless the READMEs are very very good. Either say something like "See the README for details" or inline explanations here.

Also... those are example-* repos. Those are explicitly unmaintained by us. Should these be moved to template builder?

@GuGuss GuGuss changed the title WIP: Prepare Java docs for GA Java GA Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.