Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: provide feedback on file upload #127

Closed
myitcv opened this issue Oct 7, 2020 · 7 comments
Closed

ui: provide feedback on file upload #127

myitcv opened this issue Oct 7, 2020 · 7 comments
Labels
enhancement New feature or request frontend JavaScript frontend issues

Comments

@myitcv
Copy link
Collaborator

myitcv commented Oct 7, 2020

Related to #126, we should give some visual indication within a terminal that a file has been uploaded.

Consider:

Screen Shot 2020-10-07 at 10 50 51

There is no way of knowing (from looking at the terminal) whether we have clicked the upload block, or when it happened.

#126 discusses a means by which we can feedback which steps have been clicked, but I think we also need to feedback to the user in the terminal when this happens too.

The simplest way of achieving this would be to send a command to the target terminal once the upload has completed. However, given it logically doesn't make much sense to run a command, we can instead send a comment, something like:

# successfully uploaded /home/gopher/readme.txt

I suspect this will require some changes in the SDK, unless we want to move to a model of preguide generating the command/code blocks (which would give us a bit more flexibility here)

cc @marcosnils

@myitcv myitcv added the enhancement New feature or request label Oct 7, 2020
@myitcv myitcv added this to the Go live milestone Oct 7, 2020
@marcosnils
Copy link
Collaborator

This is already handled by #169

@myitcv
Copy link
Collaborator Author

myitcv commented Nov 2, 2020

I just tried out #169

  • I clicked on a file block (which was successful) but that didn't result in any comment in the terminal
  • I then killed PWD and attempted an upload, but that didn't result in an error notification

Would it be best for me to create separate issues for these?

@marcosnils
Copy link
Collaborator

marcosnils commented Nov 2, 2020

Did you restart the site container after switching to this branch? Since this requires a different version of the SDK, you need to restart it so the _config.yml gets reloaded. If you can also validate that the SDK 0.0.7 is being used while testing this that would be much appreciated since there could be something missing here.

@myitcv
Copy link
Collaborator Author

myitcv commented Nov 2, 2020

I did... but let me just double check.

@myitcv
Copy link
Collaborator Author

myitcv commented Nov 2, 2020

Ah, it appears to be using v0.0.4.

@myitcv
Copy link
Collaborator Author

myitcv commented Nov 2, 2020

Switched to using v0.0.7, but still seeing the same behaviour as above. Let's go through tomorrow

@myitcv myitcv added the frontend JavaScript frontend issues label Nov 3, 2020
@marcosnils
Copy link
Collaborator

Fixed #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend JavaScript frontend issues
Projects
None yet
Development

No branches or pull requests

2 participants