New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: provide feedback on file upload #127
Comments
This is already handled by #169 |
I just tried out #169
Would it be best for me to create separate issues for these? |
Did you restart the |
I did... but let me just double check. |
Ah, it appears to be using |
Switched to using |
Fixed #169 |
Related to #126, we should give some visual indication within a terminal that a file has been uploaded.
Consider:
There is no way of knowing (from looking at the terminal) whether we have clicked the upload block, or when it happened.
#126 discusses a means by which we can feedback which steps have been clicked, but I think we also need to feedback to the user in the terminal when this happens too.
The simplest way of achieving this would be to send a command to the target terminal once the upload has completed. However, given it logically doesn't make much sense to run a command, we can instead send a comment, something like:
I suspect this will require some changes in the SDK, unless we want to move to a model of
preguide
generating the command/code blocks (which would give us a bit more flexibility here)cc @marcosnils
The text was updated successfully, but these errors were encountered: