Abstract client #39
Merged
Abstract client #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to OSX binaries aka afplay + say)
…288) and add a client exclusively for testing.
|
This looks pretty good. There's been a few changes since this Pull came in; would you mind merging master in and resolving any conflicts? A few more bits of feedback I'd like to tackle before this gets merged properly:
Okay maybe that's it. Looks pretty sharp. |
Conflicts: bin/setup config/play.example.yml
|
So, I have some concerns with testing of clients. I'd like to make TestClient more realistic and then provide a way to compare the operation of TestClient with an arbitrary client implementation which should help client maintainers keep their code quality up. But thats another day. Today |
:D
| @@ -104,6 +117,7 @@ sed -i '' "s/__OAUTH_KEY__/$client_id/" config/play.yml | |||
| sed -i '' "s/__OAUTH_SECRET__/$client_secret/" config/play.yml | |||
| sed -i '' "s/__USER__/$user/" config/play.yml | |||
| sed -i '' "s/__PASSWORD__/$password/" config/play.yml | |||
| sed -i '' "s/__CLIENT__/$client/" config/play/yml | |||
There was a problem hiding this comment.
I think you meant config/play.yml and not config/play/yml
|
blurgh. Thanks for the catch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We take Client and make it a class to be inherited by real clients. The setup script will select afplay or mpg123 based on what it can find, we also add support for mpc (the mpd client) since that is what we use at our workplace.