Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a texture has a # in the asset name, it cannot be downloaded from the editor or rendered in the view #814

Open
yaustar opened this issue Jul 5, 2022 · 8 comments
Open

If a texture has a # in the asset name, it cannot be downloaded from the editor or rendered in the view #814

yaustar opened this issue Jul 5, 2022 · 8 comments
Assignees
@yak32
Labels
area: asset import bug Something isn't working

Comments

@yaustar
Copy link
Contributor

yaustar commented Jul 5, 2022 •
edited

Repro: Add a # to any texture asset name. See that it disappears from the preview and cannot be downloaded

Kapture.2022-07-05.at.10.59.48.mp4
@yaustar yaustar added bug Something isn't working area: asset import labels Jul 5, 2022
@yaustar yaustar changed the title If a texture has a # in the asset name, it cannot be downloaded from the editor new rendered in the view If a texture has a # in the asset name, it cannot be downloaded from the editor or rendered in the view Jul 28, 2022
@sri-30 sri-30 self-assigned this Aug 17, 2022
@mvaligursky
Copy link

related to playcanvas/engine#4569

@yak32
Copy link

yak32 commented Feb 21, 2023

not CloudFront related - it doesn't work even locally

@yak32 yak32 self-assigned this Feb 21, 2023
@willeastcott
Copy link
Contributor

A # in a URL is link to a subsection on the page. For example:

https://developer.playcanvas.com/en/user-manual/introduction/#key-features

Presumably the # should be encoded.

@yak32
Copy link

yak32 commented Feb 21, 2023

Yeah I spent some time investigating it and it seems we don't encode it properly in some place

@yak32 yak32 mentioned this issue Feb 22, 2023
Merged
@yak32
Copy link

yak32 commented Feb 22, 2023

playcanvas/editor-api#60

@yaustar
Copy link
Contributor Author

yaustar commented Feb 22, 2023

Does this fix work on published builds as well?

@yak32
Copy link

yak32 commented Feb 22, 2023

published builds are not broken, it's just the editor issue

@yaustar
Copy link
Contributor Author

yaustar commented Feb 28, 2023 •
edited

This also applies to folder names and trying to load the asset in the launch tab (401 network error)

https://playcanvas.com/project/1044803/overview/folder-name-bug

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yak32 yak32

Labels
area: asset import bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@willeastcott @yak32 @yaustar @mvaligursky @sri-30