New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectangle - with position, orientation and size that can be intersected with Ray and other Shapes. #889

Open
Maksims opened this Issue Mar 27, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Maksims
Contributor

Maksims commented Mar 27, 2017

Like with BoundingBox and few other shapes, it would be good to have a rectangle, that is much simpler shape than box, and would be useful in many cases.

It would have position, rotation and size (not halfExtents please).
And would have functionality to check if it intersects with ray or other shapes.

@leecommamichael

This comment has been minimized.

Show comment
Hide comment
@leecommamichael

leecommamichael Aug 15, 2017

Is this as straightforward as adding 'rectangle.js' in 'engine/src/shape' following the practices in the shapes in that directory? For clarification; you're asking for a rectangle, not a rectangular prism, yeah?

leecommamichael commented Aug 15, 2017

Is this as straightforward as adding 'rectangle.js' in 'engine/src/shape' following the practices in the shapes in that directory? For clarification; you're asking for a rectangle, not a rectangular prism, yeah?

@guycalledfrank

This comment has been minimized.

Show comment
Hide comment
@guycalledfrank

guycalledfrank Aug 15, 2017

Contributor

I'd also add a circle.

(not halfExtents please).

That would make it harder to switch between rect/existing aabb. I would keep the halfExtents approach (or change both).

Contributor

guycalledfrank commented Aug 15, 2017

I'd also add a circle.

(not halfExtents please).

That would make it harder to switch between rect/existing aabb. I would keep the halfExtents approach (or change both).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment