Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cubemap update #2239

Merged
merged 6 commits into from Jul 3, 2020
Merged

Cubemap update #2239

merged 6 commits into from Jul 3, 2020

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 3, 2020 •
edited

This PR makes the following changes:

  • support loading cubemap without prefiltered lighting data
  • don't fire events on cubemap patch (as the old cubemap handler did). instead rely on asset:change events.
  • only set cubemap resources if they've changed
  • don't load helipad faces in the viewer (which aren't in github).
  • fix the engine bundle tests

I confirm I have signed the Contributor License Agreement.

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jul 3, 2020
@slimbuck slimbuck requested a review from a team July 3, 2020 10:29
@slimbuck slimbuck self-assigned this Jul 3, 2020
@slimbuck slimbuck merged commit 602c3eb into playcanvas:master Jul 3, 2020
@slimbuck slimbuck deleted the cubemap-update branch July 3, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slimbuck @willeastcott