From 2132f54a34a26d28e85896d1eb4ad91380958b3d Mon Sep 17 00:00:00 2001 From: Gustav Sterbrant Date: Tue, 12 Jul 2022 10:28:41 +0100 Subject: [PATCH] Reset default specular to 1. --- .../src/examples/graphics/material-translucent-specular.tsx | 1 + src/scene/materials/standard-material.js | 2 +- test/scene/materials/standard-material.test.mjs | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/examples/src/examples/graphics/material-translucent-specular.tsx b/examples/src/examples/graphics/material-translucent-specular.tsx index ef97768e54d..3ca45231941 100644 --- a/examples/src/examples/graphics/material-translucent-specular.tsx +++ b/examples/src/examples/graphics/material-translucent-specular.tsx @@ -54,6 +54,7 @@ class MaterialTranslucentSpecularExample { const createSphere = function (x: number, y: number, z: number) { const material = new pc.StandardMaterial(); material.diffuse = new pc.Color(0.7, 0.7, 0.7); + material.specular = new pc.Color(1, 1, 1); material.metalness = 0.0; material.shininess = ((z) / (NUM_SPHERES_Z - 1) * 50) + 50; material.useMetalness = true; diff --git a/src/scene/materials/standard-material.js b/src/scene/materials/standard-material.js index 15fb79bfe83..8777766000a 100644 --- a/src/scene/materials/standard-material.js +++ b/src/scene/materials/standard-material.js @@ -1010,7 +1010,7 @@ function _defineFlag(name, defaultValue) { function _defineMaterialProps() { _defineColor('ambient', new Color(0.7, 0.7, 0.7)); _defineColor('diffuse', new Color(1, 1, 1)); - _defineColor('specular', new Color(1, 1, 1)); + _defineColor('specular', new Color(0, 0, 0)); _defineColor('emissive', new Color(0, 0, 0)); _defineFloat('emissiveIntensity', 1); _defineFloat('specularityFactor', 1); diff --git a/test/scene/materials/standard-material.test.mjs b/test/scene/materials/standard-material.test.mjs index 0d609854ebb..260925a9f9a 100644 --- a/test/scene/materials/standard-material.test.mjs +++ b/test/scene/materials/standard-material.test.mjs @@ -231,9 +231,9 @@ describe('StandardMaterial', function () { expect(material.shininess).to.equal(25); expect(material.specular).to.be.instanceof(Color); - expect(material.specular.r).to.equal(1); - expect(material.specular.g).to.equal(1); - expect(material.specular.b).to.equal(1); + expect(material.specular.r).to.equal(0); + expect(material.specular.g).to.equal(0); + expect(material.specular.b).to.equal(0); expect(material.specularMap).to.be.null; expect(material.specularMapChannel).to.equal('rgb'); expect(material.specularMapOffset).to.be.an.instanceof(Vec2);