Skip to content

[Fix] Fix to particle exmaple not setting up shader correctly #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

[Fix] Fix to particle exmaple not setting up shader correctly #8045

merged 1 commit into from
Oct 10, 2025

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 10, 2025 •
edited
Loading

  • the example worked correctly, as compute shader set up this data in the scope
  • but for correctness, material needs to set up that data too as something else can overwrite it
  • cleanup the types as well

@mvaligursky mvaligursky self-assigned this Oct 10, 2025
@mvaligursky mvaligursky added bug Something isn't working area: graphics Graphics related issue labels Oct 10, 2025
@mvaligursky mvaligursky requested a review from a team October 10, 2025 12:20
@mvaligursky mvaligursky merged commit 06464d4 into main Oct 10, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-particles-example-fix branch October 10, 2025 13:07
slimbuck pushed a commit that referenced this pull request Oct 10, 2025
@mvaligursky @slimbuck
[Fix] Fix to particle exmaple not setting up shader correctly (#8045)
5c3c16d 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels

area: graphics Graphics related issue bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvaligursky @willeastcott