Skip to content

[Fix] Fix to particle exmaple not setting up shader correctly #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

[Fix] Fix to particle exmaple not setting up shader correctly #8045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/src/examples/compute/particles.example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ assetListLoader.load(() => {
fragmentWGSL: files['shader-shared.wgsl'] + files['shader-rendering.fragment.wgsl']
});

// rendering shader needs the particle storage buffer to read the particle data
material.setParameter('particles', particleStorageBuffer);

// index buffer - two triangles (6 indices) per particle using 4 vertices
const indices = new Uint32Array(numParticles * 6);
for (let i = 0; i < numParticles; ++i) {
Expand Down
3 changes: 2 additions & 1 deletion src/scene/materials/material.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { ShaderChunks } from '../shader-lib/shader-chunks.js';
* @import { UniformBufferFormat } from '../../platform/graphics/uniform-buffer-format.js';
* @import { VertexFormat } from '../../platform/graphics/vertex-format.js';
* @import { ShaderChunkMap } from '../shader-lib/shader-chunk-map.js';
* @import { StorageBuffer } from '../../platform/graphics/storage-buffer.js';
*/

// blend mode mapping to op, srcBlend and dstBlend
Expand Down Expand Up @@ -773,7 +774,7 @@ class Material {
* Sets a shader parameter on a material.
*
* @param {string} name - The name of the parameter to set.
* @param {number|number[]|Float32Array|Texture} data - The value for the specified parameter.
* @param {number|number[]|ArrayBufferView|Texture|StorageBuffer} data - The value for the specified parameter.
*/
setParameter(name, data) {

Expand Down