From 6585eacff1facd0c4c7df771ce556cd39dea7425 Mon Sep 17 00:00:00 2001 From: Will Eastcott Date: Sat, 2 May 2026 17:35:50 +0100 Subject: [PATCH 1/3] docs: clarify spotlight cone angles are half-angles `innerConeAngle` and `outerConeAngle` on `LightComponent` are measured from the light's direction axis to the cone edge (half-angle), not from edge to edge across the cone. The previous wording ("the angle at which the spotlight cone has faded to nothing") was ambiguous and easy to misread as the full beam angle (which is the convention used in Unity, Maya, 3ds Max, Unreal, and most DCC tools), making the default of 45 appear to describe a 45 degree cone when it actually describes a 90 degree cone. This commit updates the JSDoc for both properties to state the convention explicitly and call out the resulting full beam angle, without changing any runtime behavior. Co-authored-by: Cursor --- src/framework/components/light/component.js | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/framework/components/light/component.js b/src/framework/components/light/component.js index 0eab912ca85..eee34273fd7 100644 --- a/src/framework/components/light/component.js +++ b/src/framework/components/light/component.js @@ -530,8 +530,9 @@ class LightComponent extends Component { } /** - * Sets the angle at which the spotlight cone starts to fade off. The angle is specified in - * degrees. Affects spot lights only. Defaults to 40. + * Sets the half-angle (measured in degrees from the light's direction axis to the cone edge) + * at which the spotlight cone starts to fade off. The full inner beam angle is twice this + * value. Affects spot lights only. Defaults to 40 (i.e. an 80 degree full inner beam). * * @type {number} */ @@ -542,7 +543,8 @@ class LightComponent extends Component { } /** - * Gets the angle at which the spotlight cone starts to fade off. + * Gets the half-angle (measured in degrees from the light's direction axis to the cone edge) + * at which the spotlight cone starts to fade off. * * @type {number} */ @@ -551,8 +553,9 @@ class LightComponent extends Component { } /** - * Sets the angle at which the spotlight cone has faded to nothing. The angle is specified in - * degrees. Affects spot lights only. Defaults to 45. + * Sets the half-angle (measured in degrees from the light's direction axis to the cone edge) + * at which the spotlight cone has faded to nothing. The full outer beam angle is twice this + * value. Affects spot lights only. Defaults to 45 (i.e. a 90 degree full outer beam). * * @type {number} */ @@ -563,7 +566,8 @@ class LightComponent extends Component { } /** - * Gets the angle at which the spotlight cone has faded to nothing. + * Gets the half-angle (measured in degrees from the light's direction axis to the cone edge) + * at which the spotlight cone has faded to nothing. * * @type {number} */ From 3c3140cd303a1fd462cccab41ad87cb9eeb2cb20 Mon Sep 17 00:00:00 2001 From: Will Eastcott Date: Sat, 2 May 2026 17:39:52 +0100 Subject: [PATCH 2/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/framework/components/light/component.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/framework/components/light/component.js b/src/framework/components/light/component.js index eee34273fd7..7737cb4afe3 100644 --- a/src/framework/components/light/component.js +++ b/src/framework/components/light/component.js @@ -532,7 +532,7 @@ class LightComponent extends Component { /** * Sets the half-angle (measured in degrees from the light's direction axis to the cone edge) * at which the spotlight cone starts to fade off. The full inner beam angle is twice this - * value. Affects spot lights only. Defaults to 40 (i.e. an 80 degree full inner beam). + * value. Affects spot lights only. Defaults to 40 (i.e. an 80-degree full inner beam). * * @type {number} */ From ad9f77a78522809d840a7479167805d3b097808c Mon Sep 17 00:00:00 2001 From: Will Eastcott Date: Sat, 2 May 2026 17:40:03 +0100 Subject: [PATCH 3/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/framework/components/light/component.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/framework/components/light/component.js b/src/framework/components/light/component.js index 7737cb4afe3..33f287cf54d 100644 --- a/src/framework/components/light/component.js +++ b/src/framework/components/light/component.js @@ -555,7 +555,7 @@ class LightComponent extends Component { /** * Sets the half-angle (measured in degrees from the light's direction axis to the cone edge) * at which the spotlight cone has faded to nothing. The full outer beam angle is twice this - * value. Affects spot lights only. Defaults to 45 (i.e. a 90 degree full outer beam). + * value. Affects spot lights only. Defaults to 45 (i.e. a 90-degree full outer beam). * * @type {number} */