Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCUI source fails to build from NPM build sites #154

Closed
rpaladin opened this issue Jan 25, 2022 · 4 comments
Closed

PCUI source fails to build from NPM build sites #154

rpaladin opened this issue Jan 25, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rpaladin
Copy link

Comments

When I attempt to use a CDN package build site I get package errors about PCUI failing to build.
@yaustar was able to confirm that PCUI can still be built without errors if done locally.

I hope I do not offend anyone by sharing this but PCUI at SkyPack does have a relatively low package setup rating:

Build Errors from CodePen

CodePen Reproducible Errors Project

https://codepen.io/RandomPanda/pen/ExwrPqB

Possible Solutions

The exports argument is missing in the PCUI package.json.

Package Build Sites (using CDN from SkyPack)

Hosting provider: https://codepen.io
Package build sites: https://skypack.dev & https://www.jsdelivr.com

Forum Thread

https://forum.playcanvas.com/t/pcui-framework-build-source-failing/23793/1

Final Comments

It would be great if this issue was resolved because some people who choose to use the PlayCanvas Engine-Only CDN approach will also like to use PCUI perhaps. Not to mention that the PlayCanvas Editor only allows its own PCUI.js in the editor and not at runtime.

@yaustar
Copy link
Contributor

yaustar commented Jan 25, 2022

Not to mention that the PlayCanvas Editor only allows its own PCUI.js in the editor and not at runtime.

Not sure what you mean by this? You can use PCUI.js at runtime as seen here: https://playcanvas.com/project/808700/overview/pcui-game-inspector

@rpaladin
Copy link
Author

Sorry, I was referring to the Editor PCUI folder in general that is filled with compiled JS files. Should have clarified that.

@willeastcott
Copy link
Contributor

willeastcott commented Jan 9, 2023

I believe this is now fixed with PCUI 3.1.1. See:

https://codepen.io/playcanvas/pen/LYBxwOx

@willeastcott
Copy link
Contributor

Also, I've migrated the PCUI examples to use SkyPack now and it works perfectly:

https://github.com/playcanvas/pcui/pull/262/files

As for the low SkyPack score, it was complaining that the package.json was missing the keywords property, so I've added it here:

#263

@willeastcott willeastcott self-assigned this Jan 9, 2023
@willeastcott willeastcott added the bug Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants