Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix python and ruby binding build failures #3
Copied from bugs 368 and 373 in SF.
I am not sure if it's a problem with python filter that generates swig input file and the header; or the problem is in the new swig.
The generated C file calls "member functions" as _playerc_client_t_read when in the header file only the standard playerc_client_read is defined.
My stupid idea is to do a patch which add #define _playerc_client_t_read playerc_client_read.
The proper fix would be to write/instruct swig to use the correct "global" functions.
/build/buildd/player-3.0.2+dfsg/obj-x86_64-linux-gnu/client_libs/libplayerc/bindings/python/playercPYTHON_wrap.c: In function '_wrap_playerc_client_destroy':
the rest of the build log is at:
(Copied from rtv/Stage#42)
Function `new__playerc_client_t' implicitly converted to pointer at /build/buildd/player-3.0.2+dfsg/obj-x86_64-linux-gnu/client_libs/libplayerc/bindings/python/playercPYTHON_wrap.c:50489
Function `new__playerc_client_t' implicitly converted to pointer at /build/buildd/player-3.0.2+dfsg/obj-x86_64-linux-gnu/client_libs/libplayerc/bindings/ruby/playercRUBY_wrap.c:49044
Indeed generated bindings refer to that non-existing function.
How about using a pre-generated wrapping sources for python and ruby? . With each release they can be updated and swig will no longer be a dependency for player. Good thing is, I dont want to worry about swig version changes anymore. generating wrapping sources can be done for every release. and if I want to generate it own my own, If I have proper swig which is documented on the readme or something
There have been a couple of changes to the swig generation since 3.0.2 was released. Is anyone able to re-create these issues with the latest git head?
I'm getting symbol errors when trying to import playerc from player 3.0.2:
But I'm not seeing any errors when using the latest git master branch: