Fix SQL corresponding type for Java long #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchantep
reviewed
Aug 16, 2022
| @@ -121,7 +121,7 @@ object ParameterMetaData extends JavaTimeParameterMetaData { | |||
| /** Numeric (big integer) parameter meta data */ | |||
| implicit object BigIntParameterMetaData extends ParameterMetaData[BigInt] { | |||
| val sqlType = "NUMERIC" | |||
| val jdbcType = Types.BIGINT | |||
| val jdbcType = Types.NUMERIC | |||
There was a problem hiding this comment.
That's specific to Pg, so must not be defined there
There was a problem hiding this comment.
There was a problem hiding this comment.
I've removed the change. The problem I have noticed occurs only with long types.
cchantep
requested changes
Aug 16, 2022
| @@ -121,7 +121,7 @@ object ParameterMetaData extends JavaTimeParameterMetaData { | |||
| /** Numeric (big integer) parameter meta data */ | |||
| implicit object BigIntParameterMetaData extends ParameterMetaData[BigInt] { | |||
| val sqlType = "NUMERIC" | |||
| val jdbcType = Types.BIGINT | |||
| val jdbcType = Types.NUMERIC | |||
There was a problem hiding this comment.
pgentile
changed the title
cchantep
requested changes
Aug 16, 2022
| @@ -130,13 +130,13 @@ object ParameterMetaData extends JavaTimeParameterMetaData { | |||
| } | |||
|
|
|||
| implicit object LongParameterMetaData extends ParameterMetaData[Long] { | |||
| val sqlType = BigIntParameterMetaData.sqlType | |||
| val jdbcType = BigIntParameterMetaData.jdbcType | |||
| val sqlType = "BIGINT" | |||
There was a problem hiding this comment.
Same, specific to PG, so should not happen there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #478
Purpose
Fixes
ParameterMetaDataforLongtype.Longshould be represented by the SQLBIGINTtype.Background Context
I saw this behavior because it broke an optimized query.
References
None