New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure JSON macro performance is reasonable #68

Open
gmethvin opened this Issue May 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@gmethvin
Member

gmethvin commented May 19, 2017

The way we construct the Writes implementations with the JSON macros is not particularly efficient, as I have noticed in a few real-world apps. We should devise some tests to determine how much a performance impact there is versus manually constructing the object, and see where we can improve.

@marcospereira

This comment has been minimized.

Show comment
Hide comment
@marcospereira

marcospereira May 19, 2017

Member

I wonder if it is better to have a test here or in prune.

Maybe prune is a better place since we can track the performance evolution in a scenario more close to the real apps.

What do you think?

Member

marcospereira commented May 19, 2017

I wonder if it is better to have a test here or in prune.

Maybe prune is a better place since we can track the performance evolution in a scenario more close to the real apps.

What do you think?

@gmethvin

This comment has been minimized.

Show comment
Hide comment
@gmethvin

gmethvin Jun 5, 2017

Member

We can add tests to prune but I think microbenchmarks are the best idea to track perf of individual features.

Member

gmethvin commented Jun 5, 2017

We can add tests to prune but I think microbenchmarks are the best idea to track perf of individual features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment