Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't zap com.google.gdata #181

Merged
merged 1 commit into from Jul 27, 2017
Merged

Don't zap com.google.gdata #181

merged 1 commit into from Jul 27, 2017

Conversation

@gmethvin
Copy link
Member

gmethvin commented Jul 27, 2017

Copy link
Member

richdougherty left a comment

Is there a way to test that this is fixed?

@gmethvin gmethvin force-pushed the gmethvin-patch-1 branch from 179d050 to 2bc36e3 Jul 27, 2017
@gmethvin

This comment has been minimized.

Copy link
Member Author

gmethvin commented Jul 27, 2017

I added a spec that checks that the required class is still there. I'd like to write a unit test but I'd need to refactor a bit to do it properly.

Copy link
Member

richdougherty left a comment

LGTM

@marcospereira marcospereira merged commit 7f024a2 into master Jul 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
marcospereira added a commit that referenced this pull request Jul 27, 2017
@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Jul 27, 2017

Backport to 1.x.x: 9f085de

@gmethvin gmethvin deleted the gmethvin-patch-1 branch Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.