Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to disable generating getters/setters #1033

Merged
merged 3 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@asolntsev
Copy link
Collaborator

commented Nov 27, 2016

add possibility to disable generating getters/setters
(via setting play.propertiesEnhancer.generateAccessors=false)

it's useful because generation of getters/setters and replacing all field accesses with getters/setters is the slowest part of compilation process. Many applications do not really need it.

asolntsev added some commits Nov 27, 2016

add possibility to disable generating getters/setters
via setting "play.propertiesEnhancer.generateAccessors=false"

it's useful because generation of getters/setters and replacing all field accesses with getters/setters is the slowest part of compilation process. Many applications do not really need it.

@asolntsev asolntsev merged commit 26a9499 into playframework:1.4.x Nov 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asolntsev asolntsev deleted the codeborne:disable-generating-accessors branch Nov 28, 2016

@xael-fry

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

@asolntsev Could you update the documentation for that new parameter?

asolntsev added a commit that referenced this pull request Nov 29, 2016

@asolntsev

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 29, 2016

@xael-fry I have updated documentation in branch 1.4.x. Thank you for the reminder!

@xael-fry xael-fry added this to the 1.4.4 milestone Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.