Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

[#794] FunctionalTest now saves Cookies maxAge==null again. #204

Closed
wants to merge 1 commit into from

3 participants

Tilman Potthof Havoc Pennington Morten Kjetland
Tilman Potthof

Also reported in #775, sorry for that.

Havoc Pennington
havocp commented May 04, 2011

pull request for #775 has another important fix with a similar symptom. This is the fix if you don't set maxAge in config but it also breaks if you do set maxAge in config, for a separate reason.
#189

Tilman Potthof

Opps... I also reported that one but in a different ticket #798.
Seems like we both ran into the same problems.

Morten Kjetland
Collaborator
mbknor commented June 05, 2011

thanks but ticket is closed as duplicate

Morten Kjetland mbknor closed this June 05, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 04, 2011
[#794] FunctionalTest now saves Cookies maxAge==null again. ca43fc3
This page is out of date. Refresh to see the latest.
2  framework/src/play/test/FunctionalTest.java
@@ -280,7 +280,7 @@ public InvocationContext getInvocationContext() {
280 280
                 savedCookies = new HashMap<String, Http.Cookie>();
281 281
             }
282 282
             for(Map.Entry<String,Http.Cookie> e : response.cookies.entrySet()) {
283  
-                if(e.getValue().maxAge != null && e.getValue().maxAge > 0) {
  283
+                if(e.getValue().maxAge == null || e.getValue().maxAge > 0) {
284 284
                     savedCookies.put(e.getKey(), e.getValue());
285 285
                 }
286 286
             }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.