New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug1049 #320

Closed
wants to merge 1 commit into
base: 1.2.x
from

Conversation

Projects
None yet
3 participants
@sgodbillon
Copy link
Contributor

sgodbillon commented Aug 22, 2011

Provides support for HTTP Byte Range Serving (http://tools.ietf.org/html/rfc2616#section-14.35).

If Range header is present in the request and the action throws a RenderStatic or a RenderBinary result with a local file, then Play will serve only the requested parts of this file.

@sgodbillon

This comment has been minimized.

Copy link
Contributor

sgodbillon commented Nov 23, 2011

Any comment/review ?

@mbknor

This comment has been minimized.

Copy link
Member

mbknor commented Jan 8, 2012

Is it possible to have a test case for feature?

@sgodbillon

This comment has been minimized.

Copy link
Contributor

sgodbillon commented Jan 19, 2012

I included some test cases for this feature (see the bug1089-master branch).

@sgodbillon

This comment has been minimized.

Copy link
Contributor

sgodbillon commented Jan 19, 2012

I will update the 1.2.x branch too and rebase both of them tomorrow.

@mbknor

This comment has been minimized.

Copy link
Member

mbknor commented Jan 19, 2012

nice.. I'll try to merge it soon

@sgodbillon

This comment has been minimized.

Copy link
Contributor

sgodbillon commented Jan 23, 2012

I rebased this branch onto latest 1.2.x and solved all conflicts.
The test is included.

}
}

public static ChunkedInput getChunckedInput(RandomAccessFile raf, String contentType, Channel channel, HttpRequest nettyRequest, HttpResponse nettyResponse) throws IOException {

This comment has been minimized.

@fehmicansaglam

fehmicansaglam Feb 1, 2012

There is a typo here. getChun'c'kedInput should be corrected.

nettyResponse.setHeader(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(fileLength));
}

nettyResponse.setHeader(CONTENT_TYPE, (MimeTypes.getContentType(localFile.getName(), "text/plain")));

This comment has been minimized.

@fehmicansaglam

fehmicansaglam Feb 1, 2012

It would be great if we could explicitly set the name and the content type of the file. Do you think it is possible?

@mbknor

This comment has been minimized.

Copy link
Member

mbknor commented Feb 12, 2012

@mbknor mbknor closed this Feb 12, 2012

fehmicansaglam pushed a commit to fehmicansaglam/play that referenced this pull request Apr 21, 2012

@sgodbillon sgodbillon referenced this pull request Feb 12, 2012

Closed

Bug1049 master #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment