New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse 1240 patch #438

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@ndeverge

ndeverge commented Jan 18, 2012

This patch implements the latest WebSocket protocol (Hybi13).

It follows ths Chromium changeset : http://trac.webkit.org/changeset/97249.
The official description can be found on http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-13.
A summary of the changes is available here : http://updates.html5rocks.com/2011/10/WebSockets-updated-to-latest-version-in-Chrome-Canary

It has been tested on Chrome 16.0.912.75 (Hybi13) and Firefox 9.0.1 (Hybi 8) .

It would be great if this patch could be integrated in the 1.2.5 version of Play! since WebSockets do not work with the latest official version of Google Chrome.

@ndeverge

This comment has been minimized.

Show comment
Hide comment
@ndeverge

ndeverge Jan 18, 2012

Also tested on the latest Safari (5.1.2) for Mac, which uses Hixie76.

ndeverge commented Jan 18, 2012

Also tested on the latest Safari (5.1.2) for Mac, which uses Hixie76.

@ndeverge

This comment has been minimized.

Show comment
Hide comment
@ndeverge

ndeverge Jan 30, 2012

Closing this Pull Request since it has been resolved with https://play.lighthouseapp.com/projects/57987/tickets/1397.

ndeverge commented Jan 30, 2012

Closing this Pull Request since it has been resolved with https://play.lighthouseapp.com/projects/57987/tickets/1397.

@ndeverge ndeverge closed this Jan 30, 2012

fehmicansaglam pushed a commit to fehmicansaglam/play that referenced this pull request Apr 21, 2012

fehmicansaglam pushed a commit to fehmicansaglam/play that referenced this pull request Apr 21, 2012

Merge pull request #232 from shelajev/lighthouse-438-patch
[#438] Fix play framework and hudson don't play together well: utils.py c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment