Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1464] http.exposePlayServer setting not checked on 404 #482

Merged
merged 1 commit into from May 10, 2012
Merged

[#1464] http.exposePlayServer setting not checked on 404 #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion framework/src/play/server/PlayHandler.java
View file
Open in desktop
Expand Up @@ -635,7 +635,9 @@ public static void serve404(NotFound e, ChannelHandlerContext ctx, Request reque
Logger.trace("serve404: begin");
}
HttpResponse nettyResponse = new DefaultHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.NOT_FOUND);
nettyResponse.setHeader(SERVER, signature);
if (exposePlayServer) {
nettyResponse.setHeader(SERVER, signature);
}

nettyResponse.setHeader(CONTENT_TYPE, "text/html");
Map<String, Object> binding = getBindingForErrors(e, false);
Expand Down