Show jdbc password via status only in dev mode #578

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
4 participants
Contributor

rmath commented Mar 6, 2013

Hi,

This pull request just check the current app mode and hide the DB password according to it.
I wrote it for obvious security reasons.

Contributor

Notalifeform commented Mar 8, 2013

can you add a lighthouse ticket?

Collaborator

pepite commented Mar 12, 2013

As far as I know this only occurs if you are connected locally on the machine and query localhost:9000/status, right?

Nicolas Leroux

On Mar 11, 2013, at 11:36 AM, Mathieu ANCELIN notifications@github.com wrote:

Hi,

the lighthouse ticket is at

http://play.lighthouseapp.com/projects/57987/tickets/1657-Status-command-shows-JDBC-password-in-PROD-mode#ticket-1657-1


Reply to this email directly or view it on GitHub.

@pepite pepite added a commit that referenced this pull request Apr 1, 2013

@pepite pepite Merge pull request #578 from rmath/hidePassword
Show jdbc password via status only in dev mode
97de0cb

@pepite pepite merged commit 97de0cb into playframework:master Apr 1, 2013

Thank you very much Nicolas :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment