Route priority wrong in reverse routing

[AntonFagerberg]

From the documentation:

Many routes can match the same request. If there is a conflict, the first route (in declaration order) is used.

However, the wrong route is used in this example:

routes-file:

GET     /               controllers.Application.index
GET     /use-this       controllers.Application.test
GET     /dont-use-this  controllers.Application.test

controller-file:

  def index = Action {
    Redirect(routes.Application.test())
  }

  def test = Action {
    Ok("")
  }

Visiting index will redirect to url "/dont-use-this" and not "/use-this".

This bug has appeared since upgrading to Play 2.3.

[cchantep]

Wrong reverse routing you mean?

[AntonFagerberg]

@cchantep Yes, exactly.

[gmethvin]

This was caused by the change in #2197. Previously we generated the reverse routes for all routes, and later ones that matched the same controller call would produce an unreachable code warning. Removing duplicates with a ListMap removes the warning, but causes the last route to take priority instead of the first.