New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple repos use Assets.versioned() #7521

Closed
rmcloughlin opened this Issue Jun 28, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@gmethvin

This comment has been minimized.

Member

gmethvin commented Jun 29, 2017

@rmcloughlin Are you getting deprecation warnings on compile? The method being used is the instance method Assets#versioned: https://github.com/playframework/playframework/blob/2.6.0/framework/src/play/src/main/scala/play/api/controllers/Assets.scala#L694

This may be confusing because the syntax used in the routes file makes it look static, but if you're using the injected routes generator it will assume the last part is an instance method.

@rmcloughlin

This comment has been minimized.

Contributor

rmcloughlin commented Jun 29, 2017

Ah, I thought it was deprecated because of how it appears in IntelliJ:
idea

IntelliJ seems to think that the versioned method in the routes file corresponds to this method: https://github.com/playframework/playframework/blob/2.6.0/framework/src/play/src/main/scala/play/api/controllers/Assets.scala#L542

@richdougherty

This comment has been minimized.

Member

richdougherty commented Jul 3, 2017

OK, so is this an issue with IntelliJ's Play support?

@gpgekko

This comment has been minimized.

Contributor

gpgekko commented Jul 4, 2017

Seeing this too. Play compiles and runs fine, it's just the IDE tripping up.

@gmethvin gmethvin closed this Jul 15, 2017

@pelepelin

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment