Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Race condition in body handling when Expect: 100-continue #1346

Merged
merged 1 commit into from Jul 18, 2013

Conversation

Projects
None yet
3 participants
Owner

jroper commented Jul 17, 2013

When the Expect: 100-continue header is present, the body handler gets set in another thread, which introduces a race condition between when the first chunk arrives and when that handler is actually set.

@jroper jroper Fixed 100-continue issues
* #1346 Fixed race condition when 100 continue is returned
* Fixed incompatibility between rejecting body and keep alive
* Refactored integration tests to have a more complete very low level HTTP Client
* Introduced HTTP pipelining integration tests
48891c8

play2-master-PRs #374 SUCCESS
This pull request looks good

@huntc huntc added a commit that referenced this pull request Jul 18, 2013

@huntc huntc Merge pull request #1346 from jroper/1346-100-continue-fix
Race condition in body handling when Expect: 100-continue
fdf3ec8

@huntc huntc merged commit fdf3ec8 into playframework:master Jul 18, 2013

@jroper jroper added a commit that referenced this pull request Jul 18, 2013

@jroper jroper Fixed 100-continue issues
* #1346 Fixed race condition when 100 continue is returned
* Fixed incompatibility between rejecting body and keep alive
* Refactored integration tests to have a more complete very low level HTTP Client
* Introduced HTTP pipelining integration tests
b88521b

@jroper jroper deleted the jroper:1346-100-continue-fix branch Jul 26, 2013

@jroper jroper added a commit to jroper/playframework that referenced this pull request Jul 26, 2013

@jroper jroper Backport #1346 and #1360 to 2.0 branch 170e614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment