New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Reads max and min combinators should work on any Numeric #1363

Merged
merged 2 commits into from Jul 26, 2013

Conversation

Projects
None yet
4 participants
@mariussoutier
Contributor

mariussoutier commented Jul 19, 2013

The Reads.min and Reads.max combinators in play-json currently only work on Int, but there's no reason it shouldn't work any any Numeric.

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment
Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented Jul 19, 2013

play2-master-PRs #392 SUCCESS
This pull request looks good

@mandubian

This comment has been minimized.

Show comment
Hide comment
@mandubian

mandubian Jul 19, 2013

Collaborator

Seems OK ;)

Collaborator

mandubian commented Jul 19, 2013

Seems OK ;)

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment
Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented Jul 19, 2013

play2-master-PRs #393 SUCCESS
This pull request looks good

jroper added a commit that referenced this pull request Jul 26, 2013

Merge pull request #1363 from mariussoutier/master
JSON Reads max and min combinators should work on any Numeric

@jroper jroper merged commit a7d8fed into playframework:master Jul 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment